perf tools: Rename ordered_samples bool to ordered_events

The time ordering is generic for all kinds of events, so using generic
name 'ordered_events' for ordered_samples bool in perf_tool struct.

No functional change was intended.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Acked-by: David Ahern <dsahern@gmail.com>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jean Pihet <jean.pihet@linaro.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/n/tip-07mrqzcuhsks9wfmxrzsvemz@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Jiri Olsa 2014-07-06 14:18:21 +02:00 committed by Arnaldo Carvalho de Melo
parent 8affc2b8c2
commit 0a8cb85c20
14 changed files with 19 additions and 19 deletions

View File

@ -297,7 +297,7 @@ int cmd_annotate(int argc, const char **argv, const char *prefix __maybe_unused)
.comm = perf_event__process_comm, .comm = perf_event__process_comm,
.exit = perf_event__process_exit, .exit = perf_event__process_exit,
.fork = perf_event__process_fork, .fork = perf_event__process_fork,
.ordered_samples = true, .ordered_events = true,
.ordering_requires_timestamps = true, .ordering_requires_timestamps = true,
}, },
}; };

View File

@ -360,7 +360,7 @@ static struct perf_tool tool = {
.exit = perf_event__process_exit, .exit = perf_event__process_exit,
.fork = perf_event__process_fork, .fork = perf_event__process_fork,
.lost = perf_event__process_lost, .lost = perf_event__process_lost,
.ordered_samples = true, .ordered_events = true,
.ordering_requires_timestamps = true, .ordering_requires_timestamps = true,
}; };

View File

@ -366,7 +366,7 @@ static int __cmd_inject(struct perf_inject *inject)
} else if (inject->sched_stat) { } else if (inject->sched_stat) {
struct perf_evsel *evsel; struct perf_evsel *evsel;
inject->tool.ordered_samples = true; inject->tool.ordered_events = true;
evlist__for_each(session->evlist, evsel) { evlist__for_each(session->evlist, evsel) {
const char *name = perf_evsel__name(evsel); const char *name = perf_evsel__name(evsel);

View File

@ -256,7 +256,7 @@ static int process_sample_event(struct perf_tool *tool __maybe_unused,
static struct perf_tool perf_kmem = { static struct perf_tool perf_kmem = {
.sample = process_sample_event, .sample = process_sample_event,
.comm = perf_event__process_comm, .comm = perf_event__process_comm,
.ordered_samples = true, .ordered_events = true,
}; };
static double fragmentation(unsigned long n_req, unsigned long n_alloc) static double fragmentation(unsigned long n_req, unsigned long n_alloc)

View File

@ -1058,7 +1058,7 @@ static int read_events(struct perf_kvm_stat *kvm)
struct perf_tool eops = { struct perf_tool eops = {
.sample = process_sample_event, .sample = process_sample_event,
.comm = perf_event__process_comm, .comm = perf_event__process_comm,
.ordered_samples = true, .ordered_events = true,
}; };
struct perf_data_file file = { struct perf_data_file file = {
.path = kvm->file_name, .path = kvm->file_name,
@ -1311,7 +1311,7 @@ static int kvm_events_live(struct perf_kvm_stat *kvm,
kvm->tool.exit = perf_event__process_exit; kvm->tool.exit = perf_event__process_exit;
kvm->tool.fork = perf_event__process_fork; kvm->tool.fork = perf_event__process_fork;
kvm->tool.lost = process_lost_event; kvm->tool.lost = process_lost_event;
kvm->tool.ordered_samples = true; kvm->tool.ordered_events = true;
perf_tool__fill_defaults(&kvm->tool); perf_tool__fill_defaults(&kvm->tool);
/* set defaults */ /* set defaults */

View File

@ -852,7 +852,7 @@ static int __cmd_report(bool display_info)
struct perf_tool eops = { struct perf_tool eops = {
.sample = process_sample_event, .sample = process_sample_event,
.comm = perf_event__process_comm, .comm = perf_event__process_comm,
.ordered_samples = true, .ordered_events = true,
}; };
struct perf_data_file file = { struct perf_data_file file = {
.path = input_name, .path = input_name,

View File

@ -194,7 +194,7 @@ int cmd_mem(int argc, const char **argv, const char *prefix __maybe_unused)
.lost = perf_event__process_lost, .lost = perf_event__process_lost,
.fork = perf_event__process_fork, .fork = perf_event__process_fork,
.build_id = perf_event__process_build_id, .build_id = perf_event__process_build_id,
.ordered_samples = true, .ordered_events = true,
}, },
.input_name = "perf.data", .input_name = "perf.data",
}; };

View File

@ -578,7 +578,7 @@ int cmd_report(int argc, const char **argv, const char *prefix __maybe_unused)
.attr = perf_event__process_attr, .attr = perf_event__process_attr,
.tracing_data = perf_event__process_tracing_data, .tracing_data = perf_event__process_tracing_data,
.build_id = perf_event__process_build_id, .build_id = perf_event__process_build_id,
.ordered_samples = true, .ordered_events = true,
.ordering_requires_timestamps = true, .ordering_requires_timestamps = true,
}, },
.max_stack = PERF_MAX_STACK_DEPTH, .max_stack = PERF_MAX_STACK_DEPTH,

View File

@ -1662,7 +1662,7 @@ int cmd_sched(int argc, const char **argv, const char *prefix __maybe_unused)
.comm = perf_event__process_comm, .comm = perf_event__process_comm,
.lost = perf_event__process_lost, .lost = perf_event__process_lost,
.fork = perf_sched__process_fork_event, .fork = perf_sched__process_fork_event,
.ordered_samples = true, .ordered_events = true,
}, },
.cmp_pid = LIST_HEAD_INIT(sched.cmp_pid), .cmp_pid = LIST_HEAD_INIT(sched.cmp_pid),
.sort_list = LIST_HEAD_INIT(sched.sort_list), .sort_list = LIST_HEAD_INIT(sched.sort_list),

View File

@ -1488,7 +1488,7 @@ int cmd_script(int argc, const char **argv, const char *prefix __maybe_unused)
.attr = process_attr, .attr = process_attr,
.tracing_data = perf_event__process_tracing_data, .tracing_data = perf_event__process_tracing_data,
.build_id = perf_event__process_build_id, .build_id = perf_event__process_build_id,
.ordered_samples = true, .ordered_events = true,
.ordering_requires_timestamps = true, .ordering_requires_timestamps = true,
}, },
}; };

View File

@ -1920,7 +1920,7 @@ int cmd_timechart(int argc, const char **argv,
.fork = process_fork_event, .fork = process_fork_event,
.exit = process_exit_event, .exit = process_exit_event,
.sample = process_sample_event, .sample = process_sample_event,
.ordered_samples = true, .ordered_events = true,
}, },
.proc_num = 15, .proc_num = 15,
.min_time = 1000000, .min_time = 1000000,

View File

@ -2209,7 +2209,7 @@ static int trace__replay(struct trace *trace)
trace->tool.tracing_data = perf_event__process_tracing_data; trace->tool.tracing_data = perf_event__process_tracing_data;
trace->tool.build_id = perf_event__process_build_id; trace->tool.build_id = perf_event__process_build_id;
trace->tool.ordered_samples = true; trace->tool.ordered_events = true;
trace->tool.ordering_requires_timestamps = true; trace->tool.ordering_requires_timestamps = true;
/* add tid to output */ /* add tid to output */

View File

@ -104,9 +104,9 @@ struct perf_session *perf_session__new(struct perf_data_file *file,
} }
if (tool && tool->ordering_requires_timestamps && if (tool && tool->ordering_requires_timestamps &&
tool->ordered_samples && !perf_evlist__sample_id_all(session->evlist)) { tool->ordered_events && !perf_evlist__sample_id_all(session->evlist)) {
dump_printf("WARNING: No sample_id_all support, falling back to unordered processing\n"); dump_printf("WARNING: No sample_id_all support, falling back to unordered processing\n");
tool->ordered_samples = false; tool->ordered_events = false;
} }
return session; return session;
@ -238,7 +238,7 @@ void perf_tool__fill_defaults(struct perf_tool *tool)
if (tool->build_id == NULL) if (tool->build_id == NULL)
tool->build_id = process_finished_round_stub; tool->build_id = process_finished_round_stub;
if (tool->finished_round == NULL) { if (tool->finished_round == NULL) {
if (tool->ordered_samples) if (tool->ordered_events)
tool->finished_round = process_finished_round; tool->finished_round = process_finished_round;
else else
tool->finished_round = process_finished_round_stub; tool->finished_round = process_finished_round_stub;
@ -483,7 +483,7 @@ static int flush_sample_queue(struct perf_session *s,
struct ui_progress prog; struct ui_progress prog;
int ret; int ret;
if (!tool->ordered_samples || !limit) if (!tool->ordered_events || !limit)
return 0; return 0;
if (show_progress) if (show_progress)
@ -1062,7 +1062,7 @@ static s64 perf_session__process_event(struct perf_session *session,
if (ret) if (ret)
return ret; return ret;
if (tool->ordered_samples) { if (tool->ordered_events) {
ret = perf_session_queue_event(session, event, &sample, ret = perf_session_queue_event(session, event, &sample,
file_offset); file_offset);
if (ret != -ETIME) if (ret != -ETIME)

View File

@ -40,7 +40,7 @@ struct perf_tool {
event_op2 tracing_data; event_op2 tracing_data;
event_op2 finished_round, event_op2 finished_round,
build_id; build_id;
bool ordered_samples; bool ordered_events;
bool ordering_requires_timestamps; bool ordering_requires_timestamps;
}; };