iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

h8300: add show_stack_loglvl()

Browse Source 
Currently, the log-level of show_stack() depends on a platform
realization.  It creates situations where the headers are printed with
lower log level or higher than the stacktrace (depending on a platform or
user).

Furthermore, it forces the logic decision from user to an architecture
side.  In result, some users as sysrq/kdb/etc are doing tricks with
temporary rising console_loglevel while printing their messages.  And in
result it not only may print unwanted messages from other CPUs, but also
omit printing at all in the unlucky case where the printk() was deferred.

Introducing log-level parameter and KERN_UNSUPPRESSED [1] seems an easier
approach than introducing more printk buffers.  Also, it will consolidate
printings with headers.

Introduce show_stack_loglvl(), that eventually will substitute
show_stack().

[1]: https://lore.kernel.org/lkml/20190528002412.1625-1-dima@arista.com/T/#u

Signed-off-by: Dmitry Safonov <dima@arista.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
Link: http://lkml.kernel.org/r/20200418201944.482088-14-dima@arista.com
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Dmitry Safonov 2020-06-08 21:30:35 -07:00 committed by Linus Torvalds
parent aeeb59d692
commit 0b2ad0c7ae
1 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
arch/h8300/kernel/traps.c
View File

@ -115,7 +115,8 @@ void die(const char *str, struct pt_regs *fp, unsigned long err)
static int kstack_depth_to_print = 24; static int kstack_depth_to_print = 24;
void show_stack(struct task_struct *task, unsigned long *esp) void show_stack_loglvl(struct task_struct *task, unsigned long *esp,
const char *loglvl)
{ {
unsigned long *stack, addr; unsigned long *stack, addr;
int i; int i;
@ -125,17 +126,17 @@ void show_stack(struct task_struct *task, unsigned long *esp)
stack = esp; stack = esp;
pr_info("Stack from %08lx:", (unsigned long)stack); printk("%sStack from %08lx:", loglvl, (unsigned long)stack);
for (i = 0; i < kstack_depth_to_print; i++) { for (i = 0; i < kstack_depth_to_print; i++) {
if (((unsigned long)stack & (THREAD_SIZE - 1)) >= if (((unsigned long)stack & (THREAD_SIZE - 1)) >=
THREAD_SIZE-4) THREAD_SIZE-4)
break; break;
if (i % 8 == 0) if (i % 8 == 0)
pr_info(" "); printk("%s ", loglvl);
pr_cont(" %08lx", *stack++); pr_cont(" %08lx", *stack++);
} }
pr_info("\nCall Trace:\n"); printk("%s\nCall Trace:\n", loglvl);
i = 0; i = 0;
stack = esp; stack = esp;
while (((unsigned long)stack & (THREAD_SIZE - 1)) < THREAD_SIZE-4) { while (((unsigned long)stack & (THREAD_SIZE - 1)) < THREAD_SIZE-4) {
@ -150,10 +151,15 @@ void show_stack(struct task_struct *task, unsigned long *esp)
*/ */
if (check_kernel_text(addr)) { if (check_kernel_text(addr)) {
if (i % 4 == 0) if (i % 4 == 0)
pr_info(" "); printk("%s ", loglvl);
pr_cont(" [<%08lx>]", addr); pr_cont(" [<%08lx>]", addr);
i++; i++;
} }
} }
pr_info("\n"); printk("%s\n", loglvl);
}
void show_stack(struct task_struct *task, unsigned long *esp)
{
show_stack_loglvl(task, esp, KERN_INFO);
} }