iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

greybus: don't use 0 as an operation id

Browse Source 
Stop allowing 0x0000 to be used as an operation id.  That id will be
reserved for use by operations that will return no response message.

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
This commit is contained in:
Alex Elder 2014-12-03 08:35:06 -06:00 committed by Greg Kroah-Hartman
parent c939c2f8fe
commit 0ba02c4d16
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/staging/greybus/operation.c
View File

@ -151,10 +151,11 @@ static void gb_pending_operation_insert(struct gb_operation *operation)
/*
* Assign the operation's id and move it into its
* connection's pending list.
* connection's pending list. Zero is a reserved operation
* id.
*/
spin_lock_irq(&gb_operations_lock);
operation->id = ++connection->op_cycle;
operation->id = ++connection->op_cycle % U16_MAX + 1;
list_move_tail(&operation->links, &connection->pending);
spin_unlock_irq(&gb_operations_lock);