iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

perf inject: Call dso__put() even if dso->hit is set

Browse Source 
Otherwise it'll leak the refcount for the DSO.  As dso__put() can
handle a NULL dso pointer, we can just call it unconditionally.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Jiri Olsa <jolsa@redhat.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lore.kernel.org/lkml/20210524225051.1190486-1-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Namhyung Kim 2021-05-24 15:50:50 -07:00 committed by Arnaldo Carvalho de Melo
parent a92bf335fd
commit 0c3f7b38d7
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tools/perf/builtin-inject.c
View File

@ -383,8 +383,8 @@ static int perf_event__repipe_buildid_mmap(struct perf_tool *tool,
if (dso && !dso->hit) { if (dso && !dso->hit) {
dso->hit = 1; dso->hit = 1;
dso__inject_build_id(dso, tool, machine, sample->cpumode, 0); dso__inject_build_id(dso, tool, machine, sample->cpumode, 0);
dso__put(dso);
} }
dso__put(dso);
return perf_event__repipe(tool, event, sample, machine); return perf_event__repipe(tool, event, sample, machine);
} }
@ -447,8 +447,8 @@ static int perf_event__repipe_buildid_mmap2(struct perf_tool *tool,
dso->hit = 1; dso->hit = 1;
dso__inject_build_id(dso, tool, machine, sample->cpumode, dso__inject_build_id(dso, tool, machine, sample->cpumode,
event->mmap2.flags); event->mmap2.flags);
dso__put(dso);
} }
dso__put(dso);
perf_event__repipe(tool, event, sample, machine); perf_event__repipe(tool, event, sample, machine);