iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

staging: comedi: cb_pcidas: fix comments in *_cmdtest functions

Browse Source 
Remove some cut-and-paste comments from the skel driver in the
*_cmdtest functions. Shorten some others to fix the checkpatch.pl
complaints about WARNING: line over 80 characters.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
H Hartley Sweeten 2012-06-26 18:06:08 -07:00 committed by Greg Kroah-Hartman
parent 55acaf2d10
commit 0c4ef0b90c
1 changed files with 6 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
drivers/staging/comedi/drivers/cb_pcidas.c
View File

@ -809,14 +809,7 @@ static int cb_pcidas_ai_cmdtest(struct comedi_device *dev,
int tmp; int tmp;
int i, gain, start_chan; int i, gain, start_chan;
/* cmdtest tests a particular command to see if it is valid. /* step 1: trigger sources are trivially valid */
* Using the cmdtest ioctl, a user can create a valid cmd
* and then have it executes by the cmd ioctl.
*
* cmdtest returns 1,2,3,4 or 0, depending on which tests
* the command passes. */
/* step 1: make sure trigger sources are trivially valid */
tmp = cmd->start_src; tmp = cmd->start_src;
cmd->start_src &= TRIG_NOW | TRIG_EXT; cmd->start_src &= TRIG_NOW | TRIG_EXT;
@ -846,7 +839,7 @@ static int cb_pcidas_ai_cmdtest(struct comedi_device *dev,
if (err) if (err)
return 1; return 1;
/* step 2: make sure trigger sources are unique and mutually compatible */ /* step 2: trigger sources are unique and mutually compatible */
if (cmd->start_src != TRIG_NOW && cmd->start_src != TRIG_EXT) if (cmd->start_src != TRIG_NOW && cmd->start_src != TRIG_EXT)
err++; err++;
@ -872,7 +865,7 @@ static int cb_pcidas_ai_cmdtest(struct comedi_device *dev,
if (err) if (err)
return 2; return 2;
/* step 3: make sure arguments are trivially compatible */ /* step 3: arguments are trivially compatible */
switch (cmd->start_src) { switch (cmd->start_src) {
case TRIG_EXT: case TRIG_EXT:
@ -1092,14 +1085,7 @@ static int cb_pcidas_ao_cmdtest(struct comedi_device *dev,
int err = 0; int err = 0;
int tmp; int tmp;
/* cmdtest tests a particular command to see if it is valid. /* step 1: trigger sources are trivially valid */
* Using the cmdtest ioctl, a user can create a valid cmd
* and then have it executes by the cmd ioctl.
*
* cmdtest returns 1,2,3,4 or 0, depending on which tests
* the command passes. */
/* step 1: make sure trigger sources are trivially valid */
tmp = cmd->start_src; tmp = cmd->start_src;
cmd->start_src &= TRIG_INT; cmd->start_src &= TRIG_INT;
@ -1129,7 +1115,7 @@ static int cb_pcidas_ao_cmdtest(struct comedi_device *dev,
if (err) if (err)
return 1; return 1;
/* step 2: make sure trigger sources are unique and mutually compatible */ /* step 2: trigger sources are unique and mutually compatible */
if (cmd->scan_begin_src != TRIG_TIMER && if (cmd->scan_begin_src != TRIG_TIMER &&
cmd->scan_begin_src != TRIG_EXT) cmd->scan_begin_src != TRIG_EXT)
@ -1140,7 +1126,7 @@ static int cb_pcidas_ao_cmdtest(struct comedi_device *dev,
if (err) if (err)
return 2; return 2;
/* step 3: make sure arguments are trivially compatible */ /* step 3: arguments are trivially compatible */
if (cmd->start_arg != 0) { if (cmd->start_arg != 0) {
cmd->start_arg = 0; cmd->start_arg = 0;