iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Input: chipone_icn8318 - simplify with dev_err_probe()

Browse Source 
Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20230625162817.100397-9-krzysztof.kozlowski@linaro.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
This commit is contained in:
Krzysztof Kozlowski
2023-06-25 18:28:01 +02:00
committed by Dmitry Torokhov
parent 64eb0f741e
commit 0d9025a46b
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/input/touchscreen/chipone_icn8318.c
View File

@ -191,12 +191,8 @@ static int icn8318_probe(struct i2c_client *client)
return -ENOMEM; return -ENOMEM;
data->wake_gpio = devm_gpiod_get(dev, "wake", GPIOD_OUT_LOW); data->wake_gpio = devm_gpiod_get(dev, "wake", GPIOD_OUT_LOW);
if (IS_ERR(data->wake_gpio)) { if (IS_ERR(data->wake_gpio))
error = PTR_ERR(data->wake_gpio); return dev_err_probe(dev, PTR_ERR(data->wake_gpio), "Error getting wake gpio\n");
if (error != -EPROBE_DEFER)
dev_err(dev, "Error getting wake gpio: %d\n", error);
return error;
}
input = devm_input_allocate_device(dev); input = devm_input_allocate_device(dev);
if (!input) if (!input)