iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

pci: intr-remap: Free irte memory if SPARSE_IRQ=y

Browse Source 
With SPARSE_IRQ=y the irte descriptors are dynamically allocated, but not
freed in free_irte().

That was ok as long as the sparse irq core was not freeing irq descriptors on
destroy_irq(). Now we leak the irte descriptor. Free it in free_irte().

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Ingo Molnar <mingo@elte.hu>
Acked-by: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
This commit is contained in:
Thomas Gleixner 2010-10-04 16:20:16 +02:00
parent bc5fdf9f3a
commit 0e1e367aab
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/pci/intr_remapping.c
View File

@ -95,6 +95,15 @@ static struct irq_2_iommu *irq_2_iommu_alloc(unsigned int irq)
return desc->irq_2_iommu; return desc->irq_2_iommu;
} }
static void irq_2_iommu_free(unsigned int irq)
{
struct irq_data *d = irq_get_irq_data(irq);
struct irq_2_iommu *p = d->irq_2_iommu;
d->irq_2_iommu = NULL;
kfree(p);
}
#else /* !CONFIG_SPARSE_IRQ */ #else /* !CONFIG_SPARSE_IRQ */
static struct irq_2_iommu irq_2_iommuX[NR_IRQS]; static struct irq_2_iommu irq_2_iommuX[NR_IRQS];
@ -110,6 +119,9 @@ static struct irq_2_iommu *irq_2_iommu_alloc(unsigned int irq)
{ {
return irq_2_iommu(irq); return irq_2_iommu(irq);
} }
static void irq_2_iommu_free(unsigned int irq) { }
#endif #endif
static DEFINE_SPINLOCK(irq_2_ir_lock); static DEFINE_SPINLOCK(irq_2_ir_lock);
@ -440,6 +452,8 @@ int free_irte(int irq)
spin_unlock_irqrestore(&irq_2_ir_lock, flags); spin_unlock_irqrestore(&irq_2_ir_lock, flags);
irq_2_iommu_free(irq);
return rc; return rc;
} }