iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bpf: sockmap, fix uninitialized variable

Browse Source 
There is a potential execution path in which variable err is
returned without being properly initialized previously.

Fix this by initializing variable err to 0.

Addresses-Coverity-ID: 1468964 ("Uninitialized scalar variable")
Fixes: e5cd3abcb3 ("bpf: sockmap, refactor sockmap routines to work with hashmap")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: John Fastabend <john.fastabend@gmail.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
This commit is contained in:
Gustavo A. R. Silva 2018-05-17 09:08:43 -05:00 committed by Daniel Borkmann
parent eeacb7166d
commit 0e43645603
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
kernel/bpf/sockmap.c
View File

@ -1713,7 +1713,7 @@ static int __sock_map_ctx_update_elem(struct bpf_map *map,
struct smap_psock_map_entry *e = NULL; struct smap_psock_map_entry *e = NULL;
struct smap_psock *psock; struct smap_psock *psock;
bool new = false; bool new = false;
int err; int err = 0;
/* 1. If sock map has BPF programs those will be inherited by the /* 1. If sock map has BPF programs those will be inherited by the
* sock being added. If the sock is already attached to BPF programs * sock being added. If the sock is already attached to BPF programs