iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

thunderbolt: Fix possible NULL pointer dereference in tb_acpi_add_link()

Browse Source 
commit 4d395c5e74 upstream.

When we walk up the device hierarchy in tb_acpi_add_link() make sure we
break the loop if the device has no parent. Otherwise we may crash the
kernel by dereferencing a NULL pointer.

Fixes: b2be2b05cf ("thunderbolt: Create device links from ACPI description")
Cc: stable@vger.kernel.org
Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
Acked-by: Yehezkel Bernat <YehezkelShB@gmail.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Mario Limonciello
2020-10-26 19:12:59 +03:00
committed by Greg Kroah-Hartman
parent 19155473f3
commit 0e5cb872fb
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/thunderbolt/acpi.c
View File

@ -56,7 +56,7 @@ static acpi_status tb_acpi_add_link(acpi_handle handle, u32 level, void *data,
* managed with the xHCI and the SuperSpeed hub so we create the * managed with the xHCI and the SuperSpeed hub so we create the
* link from xHCI instead. * link from xHCI instead.
*/ */
while (!dev_is_pci(dev)) while (dev && !dev_is_pci(dev))
dev = dev->parent; dev = dev->parent;
if (!dev) if (!dev)