iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fs/configfs: Add a callback to determine attribute visibility

Browse Source 
In order to support dynamic decisions as to whether an attribute should be
created, add a callback that returns a bool to indicate whether the
attribute should be displayed. If no callback is registered, the attribute
is displayed by default.

Co-developed-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Link: https://lore.kernel.org/r/e555c8740a263fab9f83b2cbb44da1af49a2813c.1717600736.git.thomas.lendacky@amd.com
This commit is contained in:
Tom Lendacky 2024-06-05 10:18:53 -05:00 committed by Borislav Petkov (AMD)
parent 614dc0fb76
commit 0e6a35b937
2 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
fs/configfs/dir.c
View File

@ -580,6 +580,7 @@ static void detach_attrs(struct config_item * item)
static int populate_attrs(struct config_item *item) static int populate_attrs(struct config_item *item)
{ {
const struct config_item_type *t = item->ci_type; const struct config_item_type *t = item->ci_type;
struct configfs_group_operations *ops;
struct configfs_attribute *attr; struct configfs_attribute *attr;
struct configfs_bin_attribute *bin_attr; struct configfs_bin_attribute *bin_attr;
int error = 0; int error = 0;
@ -587,14 +588,23 @@ static int populate_attrs(struct config_item *item)
if (!t) if (!t)
return -EINVAL; return -EINVAL;
ops = t->ct_group_ops;
if (t->ct_attrs) { if (t->ct_attrs) {
for (i = 0; (attr = t->ct_attrs[i]) != NULL; i++) { for (i = 0; (attr = t->ct_attrs[i]) != NULL; i++) {
if (ops && ops->is_visible && !ops->is_visible(item, attr, i))
continue;
if ((error = configfs_create_file(item, attr))) if ((error = configfs_create_file(item, attr)))
break; break;
} }
} }
if (t->ct_bin_attrs) { if (t->ct_bin_attrs) {
for (i = 0; (bin_attr = t->ct_bin_attrs[i]) != NULL; i++) { for (i = 0; (bin_attr = t->ct_bin_attrs[i]) != NULL; i++) {
if (ops && ops->is_bin_visible && !ops->is_bin_visible(item, bin_attr, i))
continue;
error = configfs_create_bin_file(item, bin_attr); error = configfs_create_bin_file(item, bin_attr);
if (error) if (error)
break; break;

3
include/linux/configfs.h
View File

@ -216,6 +216,9 @@ struct configfs_group_operations {
struct config_group *(*make_group)(struct config_group *group, const char *name); struct config_group *(*make_group)(struct config_group *group, const char *name);
void (*disconnect_notify)(struct config_group *group, struct config_item *item); void (*disconnect_notify)(struct config_group *group, struct config_item *item);
void (*drop_item)(struct config_group *group, struct config_item *item); void (*drop_item)(struct config_group *group, struct config_item *item);
bool (*is_visible)(struct config_item *item, struct configfs_attribute *attr, int n);
bool (*is_bin_visible)(struct config_item *item, struct configfs_bin_attribute *attr,
int n);
}; };
struct configfs_subsystem { struct configfs_subsystem {