iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

RDMA/rtrs: Avoid Wtautological-constant-out-of-range-compare

Browse Source 
drivers/infiniband/ulp/rtrs/rtrs-clt.c:1786:19: warning: result of comparison of
constant 'MAX_SESS_QUEUE_DEPTH' (65536) with expression of type 'u16'
(aka 'unsigned short') is always false [-Wtautological-constant-out-of-range-compare]

To fix it, limit MAX_SESS_QUEUE_DEPTH to u16 max, which is 65535, and
drop the check in rtrs-clt, as it's the type u16 max.

Link: https://lore.kernel.org/r/20210531122835.58329-1-jinpu.wang@ionos.com
Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
This commit is contained in:
Jack Wang 2021-05-31 14:28:35 +02:00 committed by Jason Gunthorpe
parent 7ecd7e290b
commit 0e8558476f
2 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/infiniband/ulp/rtrs/rtrs-clt.c
View File

@ -1775,11 +1775,6 @@ static int rtrs_rdma_conn_established(struct rtrs_clt_con *con,
if (con->c.cid == 0) { if (con->c.cid == 0) {
queue_depth = le16_to_cpu(msg->queue_depth); queue_depth = le16_to_cpu(msg->queue_depth);
if (queue_depth > MAX_SESS_QUEUE_DEPTH) {
rtrs_err(clt, "Invalid RTRS message: queue=%d\n",
queue_depth);
return -ECONNRESET;
}
if (sess->queue_depth > 0 && queue_depth != sess->queue_depth) { if (sess->queue_depth > 0 && queue_depth != sess->queue_depth) {
rtrs_err(clt, "Error: queue depth changed\n"); rtrs_err(clt, "Error: queue depth changed\n");

4
drivers/infiniband/ulp/rtrs/rtrs-pri.h
View File

@ -53,9 +53,9 @@ enum {
* But mempool_create, create_qp and ib_post_send fail with * But mempool_create, create_qp and ib_post_send fail with
* "cannot allocate memory" error if sess_queue_depth is too big. * "cannot allocate memory" error if sess_queue_depth is too big.
* Therefore the pratical max value of sess_queue_depth is * Therefore the pratical max value of sess_queue_depth is
* somewhere between 1 and 65536 and it depends on the system. * somewhere between 1 and 65534 and it depends on the system.
*/ */
MAX_SESS_QUEUE_DEPTH = 65536, MAX_SESS_QUEUE_DEPTH = 65535,
MIN_CHUNK_SIZE = 8192, MIN_CHUNK_SIZE = 8192,
RTRS_HB_INTERVAL_MS = 5000, RTRS_HB_INTERVAL_MS = 5000,