sysctl: Correct error return from get_subdir
When insert_header fails ensure we return the proper error value from get_subdir. In practice nothing cares, but there is no need to be sloppy. Reported-by: Lucian Adrian Grijincu <lucian.grijincu@gmail.com> Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
This commit is contained in:
parent
51f72f4a0f
commit
0eb97f38d2
@ -869,6 +869,7 @@ static struct ctl_dir *get_subdir(struct ctl_dir *dir,
|
|||||||
{
|
{
|
||||||
struct ctl_table_set *set = dir->header.set;
|
struct ctl_table_set *set = dir->header.set;
|
||||||
struct ctl_dir *subdir, *new = NULL;
|
struct ctl_dir *subdir, *new = NULL;
|
||||||
|
int err;
|
||||||
|
|
||||||
spin_lock(&sysctl_lock);
|
spin_lock(&sysctl_lock);
|
||||||
subdir = find_subdir(dir, name, namelen);
|
subdir = find_subdir(dir, name, namelen);
|
||||||
@ -890,7 +891,9 @@ static struct ctl_dir *get_subdir(struct ctl_dir *dir,
|
|||||||
if (PTR_ERR(subdir) != -ENOENT)
|
if (PTR_ERR(subdir) != -ENOENT)
|
||||||
goto failed;
|
goto failed;
|
||||||
|
|
||||||
if (insert_header(dir, &new->header))
|
err = insert_header(dir, &new->header);
|
||||||
|
subdir = ERR_PTR(err);
|
||||||
|
if (err)
|
||||||
goto failed;
|
goto failed;
|
||||||
subdir = new;
|
subdir = new;
|
||||||
found:
|
found:
|
||||||
|
Loading…
x
Reference in New Issue
Block a user