iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

printk/index: Fix warning about missing prototypes

Browse Source 
The commit 3370155737 ("printk: Userspace format indexing support")
triggered the following build failure:

kernel/printk/index.c:140:6: warning: no previous prototype for ‘pi_create_file’ [-Wmissing-prototypes]
 void pi_create_file(struct module *mod)
      ^~~~~~~~~~~~~~
kernel/printk/index.c:146:6: warning: no previous prototype for ‘pi_remove_file’ [-Wmissing-prototypes]
 void pi_remove_file(struct module *mod)
      ^~~~~~~~~~~~~~

Fixes: 3370155737 ("printk: Userspace format indexing support")
Reported-by: kernel test robot <lkp@intel.com>
Suggested-by: Chris Down <chris@chrisdown.name>
[pmladek@suse.com: Let the compiler decide about inlining.]
Signed-off-by: Petr Mladek <pmladek@suse.com>
Link: https://lore.kernel.org/lkml/YPql089IwSpudw%2F1@alley/
This commit is contained in:
Petr Mladek 2021-07-23 09:47:07 +02:00
parent 86ce91d556
commit 0f0aa84850
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
kernel/printk/index.c
View File

@ -137,13 +137,13 @@ static const char *pi_get_module_name(struct module *mod)
} }
#endif #endif
void pi_create_file(struct module *mod) static void pi_create_file(struct module *mod)
{ {
debugfs_create_file(pi_get_module_name(mod), 0444, dfs_index, debugfs_create_file(pi_get_module_name(mod), 0444, dfs_index,
mod, &dfs_index_fops); mod, &dfs_index_fops);
} }
void pi_remove_file(struct module *mod) static void pi_remove_file(struct module *mod)
{ {
debugfs_remove(debugfs_lookup(pi_get_module_name(mod), dfs_index)); debugfs_remove(debugfs_lookup(pi_get_module_name(mod), dfs_index));
} }