iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

perf help: Ensure clean_cmds is called on all paths

Browse Source 
Avoid potential memory leaks.

Committer notes:

This is right before calling exit(1), so just to clean up memory leak
checker detection.

Signed-off-by: Ian Rogers <irogers@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: André Almeida <andrealmeid@igalia.com>
Cc: Darren Hart <dvhart@infradead.org>
Cc: Davidlohr Bueso <dave@stgolabs.net>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20230611233610.953456-2-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Ian Rogers 2023-06-11 16:36:07 -07:00 committed by Arnaldo Carvalho de Melo
parent 657a3efee4
commit 0f0d1354a5
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tools/perf/util/help-unknown-cmd.c
View File

@ -92,6 +92,7 @@ const char *help_unknown_cmd(const char *cmd)
main_cmds.names[0] = NULL; main_cmds.names[0] = NULL;
clean_cmdnames(&main_cmds); clean_cmdnames(&main_cmds);
clean_cmdnames(&other_cmds);
fprintf(stderr, "WARNING: You called a perf program named '%s', " fprintf(stderr, "WARNING: You called a perf program named '%s', "
"which does not exist.\n" "which does not exist.\n"
"Continuing under the assumption that you meant '%s'\n", "Continuing under the assumption that you meant '%s'\n",
@ -114,5 +115,7 @@ const char *help_unknown_cmd(const char *cmd)
fprintf(stderr, "\t%s\n", main_cmds.names[i]->name); fprintf(stderr, "\t%s\n", main_cmds.names[i]->name);
} }
end: end:
clean_cmdnames(&main_cmds);
clean_cmdnames(&other_cmds);
exit(1); exit(1);
} }