iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

platform/x86/intel/pmc: Display LPM requirements for multiple PMCs

Browse Source 
Update the substate_requirements attribute to display the requirements for
all the PMCs on a package.

Signed-off-by: Rajvi Jingar <rajvi.jingar@linux.intel.com>
Signed-off-by: David E. Box <david.e.box@linux.intel.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20231129222132.2331261-17-david.e.box@linux.intel.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
This commit is contained in:
Rajvi Jingar 2023-11-29 14:21:28 -08:00 committed by Hans de Goede
parent 104f74943f
commit 0f601dec18
1 changed files with 63 additions and 50 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

113
drivers/platform/x86/intel/pmc/core.c
View File

@ -728,7 +728,7 @@ static int pmc_core_substate_l_sts_regs_show(struct seq_file *s, void *unused)
} }
DEFINE_SHOW_ATTRIBUTE(pmc_core_substate_l_sts_regs); DEFINE_SHOW_ATTRIBUTE(pmc_core_substate_l_sts_regs);
static void pmc_core_substate_req_header_show(struct seq_file *s) static void pmc_core_substate_req_header_show(struct seq_file *s, int pmc_index)
{ {
struct pmc_dev *pmcdev = s->private; struct pmc_dev *pmcdev = s->private;
int i, mode; int i, mode;
@ -743,68 +743,81 @@ static void pmc_core_substate_req_header_show(struct seq_file *s)
static int pmc_core_substate_req_regs_show(struct seq_file *s, void *unused) static int pmc_core_substate_req_regs_show(struct seq_file *s, void *unused)
{ {
struct pmc_dev *pmcdev = s->private; struct pmc_dev *pmcdev = s->private;
struct pmc *pmc = pmcdev->pmcs[PMC_IDX_MAIN]; u32 sts_offset;
const struct pmc_bit_map **maps = pmc->map->lpm_sts; u32 *lpm_req_regs;
const struct pmc_bit_map *map; int num_maps, mp, pmc_index;
const int num_maps = pmc->map->lpm_num_maps;
u32 sts_offset = pmc->map->lpm_status_offset;
u32 *lpm_req_regs = pmc->lpm_req_regs;
int mp;
/* Display the header */ for (pmc_index = 0; pmc_index < ARRAY_SIZE(pmcdev->pmcs); ++pmc_index) {
pmc_core_substate_req_header_show(s); struct pmc *pmc = pmcdev->pmcs[pmc_index];
const struct pmc_bit_map **maps;
/* Loop over maps */ if (!pmc)
for (mp = 0; mp < num_maps; mp++) { continue;
u32 req_mask = 0;
u32 lpm_status; maps = pmc->map->lpm_sts;
int mode, idx, i, len = 32; num_maps = pmc->map->lpm_num_maps;
sts_offset = pmc->map->lpm_status_offset;
lpm_req_regs = pmc->lpm_req_regs;
/* /*
* Capture the requirements and create a mask so that we only * When there are multiple PMCs, though the PMC may exist, the
* show an element if it's required for at least one of the * requirement register discovery could have failed so check
* enabled low power modes * before accessing.
*/ */
pmc_for_each_mode(idx, mode, pmcdev) if (!lpm_req_regs)
req_mask |= lpm_req_regs[mp + (mode * num_maps)]; continue;
/* Get the last latched status for this map */ /* Display the header */
lpm_status = pmc_core_reg_read(pmc, sts_offset + (mp * 4)); pmc_core_substate_req_header_show(s, pmc_index);
/* Loop over elements in this map */ /* Loop over maps */
map = maps[mp]; for (mp = 0; mp < num_maps; mp++) {
for (i = 0; map[i].name && i < len; i++) { u32 req_mask = 0;
u32 bit_mask = map[i].bit_mask; u32 lpm_status;
const struct pmc_bit_map *map;
int mode, idx, i, len = 32;
if (!(bit_mask & req_mask)) /*
/* * Capture the requirements and create a mask so that we only
* Not required for any enabled states * show an element if it's required for at least one of the
* so don't display * enabled low power modes
*/ */
continue; pmc_for_each_mode(idx, mode, pmcdev)
req_mask |= lpm_req_regs[mp + (mode * num_maps)];
/* Display the element name in the first column */ /* Get the last latched status for this map */
seq_printf(s, "%30s |", map[i].name); lpm_status = pmc_core_reg_read(pmc, sts_offset + (mp * 4));
/* Loop over the enabled states and display if required */ /* Loop over elements in this map */
pmc_for_each_mode(idx, mode, pmcdev) { map = maps[mp];
if (lpm_req_regs[mp + (mode * num_maps)] & bit_mask) for (i = 0; map[i].name && i < len; i++) {
seq_printf(s, " %9s |", u32 bit_mask = map[i].bit_mask;
"Required");
else if (!(bit_mask & req_mask)) {
seq_printf(s, " %9s |", " "); /*
* Not required for any enabled states
* so don't display
*/
continue;
}
/* Display the element name in the first column */
seq_printf(s, "pmc%d: %26s |", pmc_index, map[i].name);
/* Loop over the enabled states and display if required */
pmc_for_each_mode(idx, mode, pmcdev) {
bool required = lpm_req_regs[mp + (mode * num_maps)] &
bit_mask;
seq_printf(s, " %9s |", required ? "Required" : " ");
}
/* In Status column, show the last captured state of this agent */
seq_printf(s, " %9s |", lpm_status & bit_mask ? "Yes" : " ");
seq_puts(s, "\n");
} }
/* In Status column, show the last captured state of this agent */
if (lpm_status & bit_mask)
seq_printf(s, " %9s |", "Yes");
else
seq_printf(s, " %9s |", " ");
seq_puts(s, "\n");
} }
} }
return 0; return 0;
} }
DEFINE_SHOW_ATTRIBUTE(pmc_core_substate_req_regs); DEFINE_SHOW_ATTRIBUTE(pmc_core_substate_req_regs);