iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[PATCH] mm: make __put_page internal

Browse Source 
Remove __put_page from outside the core mm/.  It is dangerous because it does
not handle compound pages nicely, and misses 1->0 transitions.  If a user
later appears that really needs the extra speed we can reevaluate.

Signed-off-by: Nick Piggin <npiggin@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
Nick Piggin 2006-03-22 00:08:33 -08:00 committed by Linus Torvalds
parent 4fa4f53bf9
commit 0f8053a509
4 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
include/linux/mm.h
View File

@ -308,7 +308,6 @@ static inline int get_page_unless_zero(struct page *page)
} }
#define set_page_count(p,v) atomic_set(&(p)->_count, (v)) #define set_page_count(p,v) atomic_set(&(p)->_count, (v))
#define __put_page(p) atomic_dec(&(p)->_count)
extern void FASTCALL(__page_cache_release(struct page *)); extern void FASTCALL(__page_cache_release(struct page *));

2
mm/filemap.c
View File

@ -30,6 +30,8 @@
#include <linux/security.h> #include <linux/security.h>
#include <linux/syscalls.h> #include <linux/syscalls.h>
#include "filemap.h" #include "filemap.h"
#include "internal.h"
/* /*
* FIXME: remove all knowledge of the buffer layer from the core VM * FIXME: remove all knowledge of the buffer layer from the core VM
*/ */

11
mm/internal.h
View File

@ -8,6 +8,10 @@
* as published by the Free Software Foundation; either version * as published by the Free Software Foundation; either version
* 2 of the License, or (at your option) any later version. * 2 of the License, or (at your option) any later version.
*/ */
#ifndef __MM_INTERNAL_H
#define __MM_INTERNAL_H
#include <linux/mm.h>
static inline void set_page_refs(struct page *page, int order) static inline void set_page_refs(struct page *page, int order)
{ {
@ -26,5 +30,12 @@ static inline void set_page_refs(struct page *page, int order)
#endif /* CONFIG_MMU */ #endif /* CONFIG_MMU */
} }
static inline void __put_page(struct page *page)
{
atomic_dec(&page->_count);
}
extern void fastcall __init __free_pages_bootmem(struct page *page, extern void fastcall __init __free_pages_bootmem(struct page *page,
unsigned int order); unsigned int order);
#endif

2
mm/vmscan.c
View File

@ -39,6 +39,8 @@
#include <linux/swapops.h> #include <linux/swapops.h>
#include "internal.h"
/* possible outcome of pageout() */ /* possible outcome of pageout() */
typedef enum { typedef enum {
/* failed to write page out, page is locked */ /* failed to write page out, page is locked */