iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

lightnvm: pblk: fix resubmission of overwritten write err lbas

Browse Source 
[ Upstream commit c12fa401ac8c94a74aff68bb5736b3f1dc695fa8 ]

Make sure we only look up valid lba addresses on the resubmission path.

If an lba is invalidated in the write buffer, that sector will be
submitted to disk (as it is already mapped to a ppa), and that write
might fail, resulting in a crash when trying to look up the lba in the
mapping table (as the lba is marked as invalid).

Signed-off-by: Hans Holmberg <hans.holmberg@cnexlabs.com>
Reviewed-by: Javier González <javier@javigon.com>
Signed-off-by: Matias Bjørling <mb@lightnvm.io>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Hans Holmberg 2018-12-11 20:16:10 +01:00 committed by Greg Kroah-Hartman
parent 3d786b91cd
commit 10014ff04a
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/lightnvm/pblk-write.c
View File

@ -158,9 +158,11 @@ static void pblk_prepare_resubmit(struct pblk *pblk, unsigned int sentry,
w_ctx = &entry->w_ctx; w_ctx = &entry->w_ctx;
/* Check if the lba has been overwritten */ /* Check if the lba has been overwritten */
ppa_l2p = pblk_trans_map_get(pblk, w_ctx->lba); if (w_ctx->lba != ADDR_EMPTY) {
if (!pblk_ppa_comp(ppa_l2p, entry->cacheline)) ppa_l2p = pblk_trans_map_get(pblk, w_ctx->lba);
w_ctx->lba = ADDR_EMPTY; if (!pblk_ppa_comp(ppa_l2p, entry->cacheline))
w_ctx->lba = ADDR_EMPTY;
}
/* Mark up the entry as submittable again */ /* Mark up the entry as submittable again */
flags = READ_ONCE(w_ctx->flags); flags = READ_ONCE(w_ctx->flags);