iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dm cache metadata: fail operations if fail_io mode has been established

Browse Source 
Otherwise it is possible to trigger crashes due to the metadata being
inaccessible yet these methods don't safely account for that possibility
without these checks.

Cc: stable@vger.kernel.org
Reported-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
This commit is contained in:
Mike Snitzer 2017-05-05 14:40:13 -04:00
parent 7ab84db64f
commit 10add84e27
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/md/dm-cache-metadata.c
View File

@ -1624,17 +1624,19 @@ void dm_cache_metadata_set_stats(struct dm_cache_metadata *cmd,
int dm_cache_commit(struct dm_cache_metadata *cmd, bool clean_shutdown) int dm_cache_commit(struct dm_cache_metadata *cmd, bool clean_shutdown)
{ {
int r; int r = -EINVAL;
flags_mutator mutator = (clean_shutdown ? set_clean_shutdown : flags_mutator mutator = (clean_shutdown ? set_clean_shutdown :
clear_clean_shutdown); clear_clean_shutdown);
WRITE_LOCK(cmd); WRITE_LOCK(cmd);
if (cmd->fail_io)
goto out;
r = __commit_transaction(cmd, mutator); r = __commit_transaction(cmd, mutator);
if (r) if (r)
goto out; goto out;
r = __begin_transaction(cmd); r = __begin_transaction(cmd);
out: out:
WRITE_UNLOCK(cmd); WRITE_UNLOCK(cmd);
return r; return r;
@ -1646,6 +1648,7 @@ int dm_cache_get_free_metadata_block_count(struct dm_cache_metadata *cmd,
int r = -EINVAL; int r = -EINVAL;
READ_LOCK(cmd); READ_LOCK(cmd);
if (!cmd->fail_io)
r = dm_sm_get_nr_free(cmd->metadata_sm, result); r = dm_sm_get_nr_free(cmd->metadata_sm, result);
READ_UNLOCK(cmd); READ_UNLOCK(cmd);
@ -1658,6 +1661,7 @@ int dm_cache_get_metadata_dev_size(struct dm_cache_metadata *cmd,
int r = -EINVAL; int r = -EINVAL;
READ_LOCK(cmd); READ_LOCK(cmd);
if (!cmd->fail_io)
r = dm_sm_get_nr_blocks(cmd->metadata_sm, result); r = dm_sm_get_nr_blocks(cmd->metadata_sm, result);
READ_UNLOCK(cmd); READ_UNLOCK(cmd);