iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

RDMA/qedr: Fix error return code in qedr_iw_connect()

Browse Source 
Fix to return a negative error code from the error handling case instead
of 0, as done elsewhere in this function.

Fixes: 82af6d19d8 ("RDMA/qedr: Fix synchronization methods and memory leaks in qedr")
Link: https://lore.kernel.org/r/20210408113135.92165-1-wangwensheng4@huawei.com
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Wensheng <wangwensheng4@huawei.com>
Acked-by: Michal Kalderon <michal.kalderon@marvell.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
This commit is contained in:
Wang Wensheng
2021-04-08 11:31:35 +00:00
committed by Jason Gunthorpe
parent 26caea5fda
commit 10dd83dbcd
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/infiniband/hw/qedr/qedr_iw_cm.c
View File

@@ -636,8 +636,10 @@ int qedr_iw_connect(struct iw_cm_id *cm_id, struct iw_cm_conn_param *conn_param)
memcpy(in_params.local_mac_addr, dev->ndev->dev_addr, ETH_ALEN); memcpy(in_params.local_mac_addr, dev->ndev->dev_addr, ETH_ALEN);
if (test_and_set_bit(QEDR_IWARP_CM_WAIT_FOR_CONNECT, if (test_and_set_bit(QEDR_IWARP_CM_WAIT_FOR_CONNECT,
&qp->iwarp_cm_flags)) &qp->iwarp_cm_flags)) {
rc = -ENODEV;
goto err; /* QP already being destroyed */ goto err; /* QP already being destroyed */
}
rc = dev->ops->iwarp_connect(dev->rdma_ctx, &in_params, &out_params); rc = dev->ops->iwarp_connect(dev->rdma_ctx, &in_params, &out_params);
if (rc) { if (rc) {