iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

usb: typec: tipd: Separate reset for TPS6598x

Browse Source 
Some platforms like SK-AM62, SK-AM62A cannot boot up to prompt if
TPS6598x is cold-reset during unconditionally on probe failures by
sending "GAID" sequence.

The probe can fail initially because USB0 remote-endpoint may not be
probed yet, which defines the usb-role-switch property.

Fixes: d49f90822015 ("usb: typec: tipd: add init and reset functions to tipd_data")
Closes: https://lore.kernel.org/linux-usb/vmngazj6si7xxss7txenezkcukqje2glhvvs7ipdcx3vjiqvlk@ohmmhhhlryws/
Signed-off-by: Jai Luthra <j-luthra@ti.com>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20240105-next-tps-fix-v1-1-158cabaec168@ti.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Jai Luthra 2024-01-05 14:36:54 +05:30 committed by Greg Kroah-Hartman
parent 2dd23cc4d0
commit 1154e43041
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/usb/typec/tipd/core.c
View File

@ -1223,11 +1223,16 @@ static int cd321x_reset(struct tps6598x *tps)
return 0;
}
static int tps6598x_reset(struct tps6598x *tps)
static int tps25750_reset(struct tps6598x *tps)
{
return tps6598x_exec_cmd_tmo(tps, "GAID", 0, NULL, 0, NULL, 2000, 0);
}
static int tps6598x_reset(struct tps6598x *tps)
{
return 0;
}
static int
tps25750_register_port(struct tps6598x *tps, struct fwnode_handle *fwnode)
{
@ -1545,7 +1550,7 @@ static const struct tipd_data tps25750_data = {
.trace_status = trace_tps25750_status,
.apply_patch = tps25750_apply_patch,
.init = tps25750_init,
.reset = tps6598x_reset,
.reset = tps25750_reset,
};
static const struct of_device_id tps6598x_of_match[] = {