iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ALSA: ak4117: Do not free priv until timer handler hasn't actually stopped using it

Browse Source 
Function del_timer() does not guarantee that timer was really deleted.
If the timer handler is beeing executed at the moment, the function
does nothing. So, it's possible to use already freed memory in the handler:

[ref: Documentation/DocBook/kernel-locking.tmpl]

This was found using grep and compile-tested only.

Signed-off-by: Kirill Tkhai <ktkhai@parallels.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Kirill Tkhai 2014-02-14 15:47:57 +04:00 committed by Takashi Iwai
parent 9ce5054363
commit 115b94d51a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sound/i2c/other/ak4117.c
View File

@ -62,7 +62,7 @@ static void reg_dump(struct ak4117 *ak4117)
static void snd_ak4117_free(struct ak4117 *chip)
{
del_timer(&chip->timer);
del_timer_sync(&chip->timer);
kfree(chip);
}