iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

let path_init() failures treated the same way as subsequent link_path_walk()

Browse Source 
As it is, path_lookupat() and path_mounpoint() might end up leaking struct file
reference in some cases.

Spotted-by: Eric Biggers <ebiggers3@gmail.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
Al Viro 2014-10-11 23:05:52 -04:00
parent 24dff96a37
commit 115cbfdc60
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
fs/namei.c
View File

@ -1950,7 +1950,7 @@ static int path_lookupat(int dfd, const char *name,
err = path_init(dfd, name, flags | LOOKUP_PARENT, nd, &base);
if (unlikely(err))
return err;
goto out;
current->total_link_count = 0;
err = link_path_walk(name, nd);
@ -1982,6 +1982,7 @@ static int path_lookupat(int dfd, const char *name,
}
}
out:
if (base)
fput(base);
@ -2301,7 +2302,7 @@ path_mountpoint(int dfd, const char *name, struct path *path, unsigned int flags
err = path_init(dfd, name, flags | LOOKUP_PARENT, &nd, &base);
if (unlikely(err))
return err;
goto out;
current->total_link_count = 0;
err = link_path_walk(name, &nd);