iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

trace: Replace single-character seq_puts with seq_putc

Browse Source 
Printing a single character to a seqfile might as well be done with
seq_putc instead of seq_puts; this avoids a strlen() call and a memory
access. It also shaves another few bytes off the generated code.

Link: http://lkml.kernel.org/r/1415479332-25944-4-git-send-email-linux@rasmusvillemoes.dk

Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
This commit is contained in:
Rasmus Villemoes
2014-11-08 21:42:12 +01:00
committed by Steven Rostedt
parent d79ac28fde
commit 1177e43641
5 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
kernel/trace/trace_events_trigger.c
View File

@@ -383,7 +383,7 @@ event_trigger_print(const char *name, struct seq_file *m,
if (filter_str) if (filter_str)
seq_printf(m, " if %s\n", filter_str); seq_printf(m, " if %s\n", filter_str);
else else
seq_puts(m, "\n"); seq_putc(m, '\n');
return 0; return 0;
} }
@@ -1105,7 +1105,7 @@ event_enable_trigger_print(struct seq_file *m, struct event_trigger_ops *ops,
if (data->filter_str) if (data->filter_str)
seq_printf(m, " if %s\n", data->filter_str); seq_printf(m, " if %s\n", data->filter_str);
else else
seq_puts(m, "\n"); seq_putc(m, '\n');
return 0; return 0;
} }

4
kernel/trace/trace_functions_graph.c
View File

@@ -1407,7 +1407,7 @@ static void __print_graph_headers_flags(struct seq_file *s, u32 flags)
print_lat_header(s, flags); print_lat_header(s, flags);
/* 1st line */ /* 1st line */
seq_puts(s, "#"); seq_putc(s, '#');
if (flags & TRACE_GRAPH_PRINT_ABS_TIME) if (flags & TRACE_GRAPH_PRINT_ABS_TIME)
seq_puts(s, " TIME "); seq_puts(s, " TIME ");
if (flags & TRACE_GRAPH_PRINT_CPU) if (flags & TRACE_GRAPH_PRINT_CPU)
@@ -1421,7 +1421,7 @@ static void __print_graph_headers_flags(struct seq_file *s, u32 flags)
seq_puts(s, " FUNCTION CALLS\n"); seq_puts(s, " FUNCTION CALLS\n");
/* 2nd line */ /* 2nd line */
seq_puts(s, "#"); seq_putc(s, '#');
if (flags & TRACE_GRAPH_PRINT_ABS_TIME) if (flags & TRACE_GRAPH_PRINT_ABS_TIME)
seq_puts(s, " | "); seq_puts(s, " | ");
if (flags & TRACE_GRAPH_PRINT_CPU) if (flags & TRACE_GRAPH_PRINT_CPU)

8
kernel/trace/trace_kprobe.c
View File

@@ -1030,7 +1030,7 @@ print_kprobe_event(struct trace_iterator *iter, int flags,
if (!seq_print_ip_sym(s, field->ip, flags | TRACE_ITER_SYM_OFFSET)) if (!seq_print_ip_sym(s, field->ip, flags | TRACE_ITER_SYM_OFFSET))
goto partial; goto partial;
if (!trace_seq_puts(s, ")")) if (!trace_seq_putc(s, ')'))
goto partial; goto partial;
data = (u8 *)&field[1]; data = (u8 *)&field[1];
@@ -1039,7 +1039,7 @@ print_kprobe_event(struct trace_iterator *iter, int flags,
data + tp->args[i].offset, field)) data + tp->args[i].offset, field))
goto partial; goto partial;
if (!trace_seq_puts(s, "\n")) if (!trace_seq_putc(s, '\n'))
goto partial; goto partial;
return TRACE_TYPE_HANDLED; return TRACE_TYPE_HANDLED;
@@ -1072,7 +1072,7 @@ print_kretprobe_event(struct trace_iterator *iter, int flags,
if (!seq_print_ip_sym(s, field->func, flags & ~TRACE_ITER_SYM_OFFSET)) if (!seq_print_ip_sym(s, field->func, flags & ~TRACE_ITER_SYM_OFFSET))
goto partial; goto partial;
if (!trace_seq_puts(s, ")")) if (!trace_seq_putc(s, ')'))
goto partial; goto partial;
data = (u8 *)&field[1]; data = (u8 *)&field[1];
@@ -1081,7 +1081,7 @@ print_kretprobe_event(struct trace_iterator *iter, int flags,
data + tp->args[i].offset, field)) data + tp->args[i].offset, field))
goto partial; goto partial;
if (!trace_seq_puts(s, "\n")) if (!trace_seq_putc(s, '\n'))
goto partial; goto partial;
return TRACE_TYPE_HANDLED; return TRACE_TYPE_HANDLED;

2
kernel/trace/trace_printk.c
View File

@@ -305,7 +305,7 @@ static int t_show(struct seq_file *m, void *v)
seq_puts(m, "\\t"); seq_puts(m, "\\t");
break; break;
case '\\': case '\\':
seq_puts(m, "\\"); seq_putc(m, '\\');
break; break;
case '"': case '"':
seq_puts(m, "\\\""); seq_puts(m, "\\\"");

2
kernel/trace/trace_uprobe.c
View File

@@ -872,7 +872,7 @@ print_uprobe_event(struct trace_iterator *iter, int flags, struct trace_event *e
goto partial; goto partial;
} }
if (trace_seq_puts(s, "\n")) if (trace_seq_putc(s, '\n'))
return TRACE_TYPE_HANDLED; return TRACE_TYPE_HANDLED;
partial: partial: