iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bpf: Remove the preceding __ from __bpf_selem_unlink_storage

Browse Source 
__bpf_selem_unlink_storage is taking the spin lock and there is
no name collision also. Having the preceding '__' is confusing
when reviewing the later patch.

Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org>
Link: https://lore.kernel.org/r/20230308065936.1550103-5-martin.lau@linux.dev
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
This commit is contained in:
Martin KaFai Lau 2023-03-07 22:59:23 -08:00 committed by Alexei Starovoitov
parent 62827d612a
commit 121f31f3e0
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
kernel/bpf/bpf_local_storage.c
View File

@ -216,8 +216,8 @@ static bool bpf_selem_unlink_storage_nolock(struct bpf_local_storage *local_stor
return free_local_storage; return free_local_storage;
} }
static void __bpf_selem_unlink_storage(struct bpf_local_storage_elem *selem, static void bpf_selem_unlink_storage(struct bpf_local_storage_elem *selem,
bool use_trace_rcu) bool use_trace_rcu)
{ {
struct bpf_local_storage *local_storage; struct bpf_local_storage *local_storage;
bool free_local_storage = false; bool free_local_storage = false;
@ -288,7 +288,7 @@ void bpf_selem_unlink(struct bpf_local_storage_elem *selem, bool use_trace_rcu)
* the local_storage. * the local_storage.
*/ */
bpf_selem_unlink_map(selem); bpf_selem_unlink_map(selem);
__bpf_selem_unlink_storage(selem, use_trace_rcu); bpf_selem_unlink_storage(selem, use_trace_rcu);
} }
/* If cacheit_lockit is false, this lookup function is lockless */ /* If cacheit_lockit is false, this lookup function is lockless */