iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

media: ov2680: Drop unnecessary pad checks

Browse Source 
Drop unnecessary pad checks in enum_mbus_code, get_fmt, set_fmt
this is already checked by check_pad() from
drivers/media/v4l2-core/v4l2-subdev.c.

Acked-by: Rui Miguel Silva <rmfrfs@gmail.com>
Reviewed-by: Daniel Scally <dan.scally@ideasonboard.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
This commit is contained in:
Hans de Goede 2023-08-03 11:33:41 +02:00 committed by Mauro Carvalho Chehab
parent 9b8e6ee867
commit 1259259f56
1 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/media/i2c/ov2680.c
View File

@ -591,7 +591,7 @@ static int ov2680_enum_mbus_code(struct v4l2_subdev *sd,
{
struct ov2680_dev *sensor = to_ov2680_dev(sd);
if (code->pad != 0 || code->index != 0)
if (code->index != 0)
return -EINVAL;
code->code = sensor->mode.fmt.code;
@ -606,9 +606,6 @@ static int ov2680_get_fmt(struct v4l2_subdev *sd,
struct ov2680_dev *sensor = to_ov2680_dev(sd);
struct v4l2_mbus_framefmt *fmt;
if (format->pad != 0)
return -EINVAL;
fmt = __ov2680_get_pad_format(sensor, sd_state, format->pad,
format->which);
@ -629,9 +626,6 @@ static int ov2680_set_fmt(struct v4l2_subdev *sd,
unsigned int width, height;
int ret = 0;
if (format->pad != 0)
return -EINVAL;
crop = __ov2680_get_pad_crop(sensor, sd_state, format->pad,
format->which);