iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

drm/tilcdc: panel: Set return value explicitly

Browse Source 
Instead of setting an initial value for the return code, set it explicitly
on each error path. This is just a cosmetic cleanup, as preparation for the
enable GPIO support.

Tested-by: Darren Etheridge <detheridge@ti.com>
Tested-by: Johannes Pointner <johannes.pointner@br-automation.com>
Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Signed-off-by: Dave Airlie <airlied@redhat.com>
This commit is contained in:
Ezequiel Garcia
2014-09-02 09:51:21 -03:00
committed by Dave Airlie
parent 18c44db8ca
commit 12778fc143
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/gpu/drm/tilcdc/tilcdc_panel.c
View File

@ -346,7 +346,7 @@ static int panel_probe(struct platform_device *pdev)
struct panel_module *panel_mod; struct panel_module *panel_mod;
struct tilcdc_module *mod; struct tilcdc_module *mod;
struct pinctrl *pinctrl; struct pinctrl *pinctrl;
int ret = -EINVAL; int ret;
/* bail out early if no DT data: */ /* bail out early if no DT data: */
if (!node) { if (!node) {
@ -381,12 +381,14 @@ static int panel_probe(struct platform_device *pdev)
panel_mod->timings = of_get_display_timings(node); panel_mod->timings = of_get_display_timings(node);
if (!panel_mod->timings) { if (!panel_mod->timings) {
dev_err(&pdev->dev, "could not get panel timings\n"); dev_err(&pdev->dev, "could not get panel timings\n");
ret = -EINVAL;
goto fail_free; goto fail_free;
} }
panel_mod->info = of_get_panel_info(node); panel_mod->info = of_get_panel_info(node);
if (!panel_mod->info) { if (!panel_mod->info) {
dev_err(&pdev->dev, "could not get panel info\n"); dev_err(&pdev->dev, "could not get panel info\n");
ret = -EINVAL;
goto fail_timings; goto fail_timings;
} }