iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

misc: xilinx_sdfec: Return -EFAULT if copy_from_user() fails

Browse Source 
The copy_from_user() function returns the number of bytes remaining to
be copied but we want to return -EFAULT to the user.

Fixes: 20ec628e80 ("misc: xilinx_sdfec: Add ability to configure LDPC")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Michal Simek <michal.simek@xilinx.com>
Reviewed-by: Dragan Cvetic <dragan.cvetic@xilinx.com>
Link: https://lore.kernel.org/r/20190822083105.GI3964@kadam
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Dan Carpenter 2019-08-22 11:31:05 +03:00 committed by Greg Kroah-Hartman
parent dac4f1964a
commit 129c3b082c
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/misc/xilinx_sdfec.c
View File

@ -651,9 +651,10 @@ static int xsdfec_add_ldpc(struct xsdfec_dev *xsdfec, void __user *arg)
if (!ldpc)
return -ENOMEM;
ret = copy_from_user(ldpc, arg, sizeof(*ldpc));
if (ret)
if (copy_from_user(ldpc, arg, sizeof(*ldpc))) {
ret = -EFAULT;
goto err_out;
}
if (xsdfec->config.code == XSDFEC_TURBO_CODE) {
ret = -EIO;