iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mlxsw: spectrum_ptp: Fix compilation warnings

Browse Source 
In case that 'CONFIG_PTP_1588_CLOCK' is not enabled in the config file,
there are implementations for the functions
mlxsw_{sp,sp2}_ptp_txhdr_construct() as part of 'spectrum_ptp.h'. In this
case, they should be defined as 'static' as they are not supposed to be
used out of this file. Make the functions 'static', otherwise the following
warnings are returned:

"warning: no previous prototype for 'mlxsw_sp_ptp_txhdr_construct'"
"warning: no previous prototype for 'mlxsw_sp2_ptp_txhdr_construct'"

In addition, make the functions 'inline' for case that 'spectrum_ptp.h'
will be included anywhere else and the functions would probably not be
used, so compilation warnings about unused static will be returned.

Fixes: 24157bc69f45 ("mlxsw: Send PTP packets as data packets to overcome a limitation")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Amit Cohen <amcohen@nvidia.com>
Reviewed-by: Petr Machata <petrm@nvidia.com>
Signed-off-by: Petr Machata <petrm@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Amit Cohen 2022-08-12 17:32:00 +02:00 committed by David S. Miller
parent 0279957171
commit 12e091389b
1 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
drivers/net/ethernet/mellanox/mlxsw/spectrum_ptp.h
View File

@ -171,10 +171,11 @@ static inline void mlxsw_sp1_get_stats(struct mlxsw_sp_port *mlxsw_sp_port,
{ {
} }
int mlxsw_sp_ptp_txhdr_construct(struct mlxsw_core *mlxsw_core, static inline int
struct mlxsw_sp_port *mlxsw_sp_port, mlxsw_sp_ptp_txhdr_construct(struct mlxsw_core *mlxsw_core,
struct sk_buff *skb, struct mlxsw_sp_port *mlxsw_sp_port,
const struct mlxsw_tx_info *tx_info) struct sk_buff *skb,
const struct mlxsw_tx_info *tx_info)
{ {
return -EOPNOTSUPP; return -EOPNOTSUPP;
} }
@ -231,10 +232,11 @@ static inline int mlxsw_sp2_ptp_get_ts_info(struct mlxsw_sp *mlxsw_sp,
return mlxsw_sp_ptp_get_ts_info_noptp(info); return mlxsw_sp_ptp_get_ts_info_noptp(info);
} }
int mlxsw_sp2_ptp_txhdr_construct(struct mlxsw_core *mlxsw_core, static inline int
struct mlxsw_sp_port *mlxsw_sp_port, mlxsw_sp2_ptp_txhdr_construct(struct mlxsw_core *mlxsw_core,
struct sk_buff *skb, struct mlxsw_sp_port *mlxsw_sp_port,
const struct mlxsw_tx_info *tx_info) struct sk_buff *skb,
const struct mlxsw_tx_info *tx_info)
{ {
return -EOPNOTSUPP; return -EOPNOTSUPP;
} }