iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

spi: spi-fsl-dspi: Reduce indentation level in dspi_interrupt

Browse Source 
If the entire function depends on the SPI status register having the
interrupt bits asserted, then just check it and exit early if those bits
aren't set (such as in the case of the shared IRQ being triggered for
the other peripheral). Cosmetic patch.

Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
Link: https://lore.kernel.org/r/20190822211514.19288-2-olteanv@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Vladimir Oltean 2019-08-23 00:15:10 +03:00 committed by Mark Brown
parent 795227660d
commit 12fb61a973
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 39 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/spi/spi-fsl-dspi.c
View File

@ -658,8 +658,9 @@ static irqreturn_t dspi_interrupt(int irq, void *dev_id)
regmap_read(dspi->regmap, SPI_SR, &spi_sr); regmap_read(dspi->regmap, SPI_SR, &spi_sr);
regmap_write(dspi->regmap, SPI_SR, spi_sr); regmap_write(dspi->regmap, SPI_SR, spi_sr);
if (!(spi_sr & (SPI_SR_EOQF | SPI_SR_TCFQF)))
return IRQ_HANDLED;
if (spi_sr & (SPI_SR_EOQF | SPI_SR_TCFQF)) {
/* Get transfer counter (in number of SPI transfers). It was /* Get transfer counter (in number of SPI transfers). It was
* reset to 0 when transfer(s) were started. * reset to 0 when transfer(s) were started.
*/ */
@ -685,7 +686,9 @@ static irqreturn_t dspi_interrupt(int irq, void *dev_id)
if (!dspi->len) { if (!dspi->len) {
dspi->waitflags = 1; dspi->waitflags = 1;
wake_up_interruptible(&dspi->waitq); wake_up_interruptible(&dspi->waitq);
} else { return IRQ_HANDLED;
}
switch (trans_mode) { switch (trans_mode) {
case DSPI_EOQ_MODE: case DSPI_EOQ_MODE:
dspi_eoq_write(dspi); dspi_eoq_write(dspi);
@ -698,8 +701,6 @@ static irqreturn_t dspi_interrupt(int irq, void *dev_id)
"unsupported trans_mode %u\n", "unsupported trans_mode %u\n",
trans_mode); trans_mode);
} }
}
}
return IRQ_HANDLED; return IRQ_HANDLED;
} }