iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

misc: pci_endpoint_test: Remove usage of the deprecated ida_simple_*() API

Browse Source 
ida_alloc() and ida_free() should be preferred to the deprecated
ida_simple_get() and ida_simple_remove() functions.

This is also less verbose.

Link: https://lore.kernel.org/linux-pci/47a30441242c4d5f0e00555cbddd7783350ff1b2.1702966523.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
This commit is contained in:
Christophe JAILLET 2023-12-19 07:15:37 +01:00 committed by Krzysztof Wilczyński
parent 0eccea7150
commit 130f335630
No known key found for this signature in database
GPG Key ID: 7C64768D3DE334E7
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/misc/pci_endpoint_test.c
View File

@ -860,7 +860,7 @@ static int pci_endpoint_test_probe(struct pci_dev *pdev,
pci_set_drvdata(pdev, test); pci_set_drvdata(pdev, test);
id = ida_simple_get(&pci_endpoint_test_ida, 0, 0, GFP_KERNEL); id = ida_alloc(&pci_endpoint_test_ida, GFP_KERNEL);
if (id < 0) { if (id < 0) {
err = id; err = id;
dev_err(dev, "Unable to get id\n"); dev_err(dev, "Unable to get id\n");
@ -907,7 +907,7 @@ err_kfree_test_name:
kfree(test->name); kfree(test->name);
err_ida_remove: err_ida_remove:
ida_simple_remove(&pci_endpoint_test_ida, id); ida_free(&pci_endpoint_test_ida, id);
err_iounmap: err_iounmap:
for (bar = 0; bar < PCI_STD_NUM_BARS; bar++) { for (bar = 0; bar < PCI_STD_NUM_BARS; bar++) {
@ -943,7 +943,7 @@ static void pci_endpoint_test_remove(struct pci_dev *pdev)
misc_deregister(&test->miscdev); misc_deregister(&test->miscdev);
kfree(misc_device->name); kfree(misc_device->name);
kfree(test->name); kfree(test->name);
ida_simple_remove(&pci_endpoint_test_ida, id); ida_free(&pci_endpoint_test_ida, id);
for (bar = 0; bar < PCI_STD_NUM_BARS; bar++) { for (bar = 0; bar < PCI_STD_NUM_BARS; bar++) {
if (test->bar[bar]) if (test->bar[bar])
pci_iounmap(pdev, test->bar[bar]); pci_iounmap(pdev, test->bar[bar]);