iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mmc: atmel-mci: add missing of_node_put

Browse Source 
for_each_child_of_node performs an of_node_get on each
iteration, so a break out of the loop requires an
of_node_put.

This was done using the Coccinelle semantic patch
iterators/for_each_child.cocci

Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Link: https://lore.kernel.org/r/20230907095521.14053-6-Julia.Lawall@inria.fr
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
This commit is contained in:
Julia Lawall 2023-09-07 11:55:15 +02:00 committed by Ulf Hansson
parent bbe6dc429b
commit 134d3cfbb8
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/mmc/host/atmel-mci.c
View File

@ -674,8 +674,10 @@ atmci_of_init(struct platform_device *pdev)
"cd", GPIOD_IN, "cd-gpios");
err = PTR_ERR_OR_ZERO(pdata->slot[slot_id].detect_pin);
if (err) {
if (err != -ENOENT)
if (err != -ENOENT) {
of_node_put(cnp);
return ERR_PTR(err);
}
pdata->slot[slot_id].detect_pin = NULL;
}
@ -687,8 +689,10 @@ atmci_of_init(struct platform_device *pdev)
"wp", GPIOD_IN, "wp-gpios");
err = PTR_ERR_OR_ZERO(pdata->slot[slot_id].wp_pin);
if (err) {
if (err != -ENOENT)
if (err != -ENOENT) {
of_node_put(cnp);
return ERR_PTR(err);
}
pdata->slot[slot_id].wp_pin = NULL;
}
}