iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

greybus: interface: fix hot-unplug control-connection timeouts

Browse Source 
Set an interface disconnected flag when the interface has been
hot-unplugged (e.g. forcibly removed or after a reboot), and use it to
disable the control connection early when deregistering the interface
and its bundles.

This avoids a one-second (default) timeout for every enabled connection
(e.g. one per bundle) at hot-unplug, something which for the default
gpbridge manifest currently amounts to five seconds.

Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
This commit is contained in:
Johan Hovold 2015-12-15 15:28:57 +01:00 committed by Greg Kroah-Hartman
parent c634650ecc
commit 141af4f054
3 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/staging/greybus/interface.c
View File

@ -130,6 +130,9 @@ void gb_interface_remove(struct gb_interface *intf)
struct gb_bundle *bundle;
struct gb_bundle *next;
if (intf->disconnected)
gb_control_disable(intf->control);
list_for_each_entry_safe(bundle, next, &intf->bundles, links)
gb_bundle_destroy(bundle);

1
drivers/staging/greybus/interface.h
View File

@ -35,6 +35,7 @@ struct gb_interface {
/* The interface needs to boot over unipro */
bool boot_over_unipro;
bool disconnected;
};
#define to_gb_interface(d) container_of(d, struct gb_interface, dev)

5
drivers/staging/greybus/svc.c
View File

@ -335,9 +335,10 @@ static int gb_svc_hello(struct gb_operation *op)
static void gb_svc_intf_remove(struct gb_svc *svc, struct gb_interface *intf)
{
u8 intf_id = intf->interface_id;
u8 device_id;
u8 device_id = intf->device_id;
intf->disconnected = true;
device_id = intf->device_id;
gb_interface_remove(intf);
/*