iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[media] v4l: vsp1: use else if instead of continue when creating links

Browse Source 
The for loop in the vsp1_create_entities() function that create the links,
checks the entity type and call the proper link creation function but then
it uses continue to force the next iteration of the loop to take place and
skipping code in between that creates links for different entities types.

It is more readable and easier to understand if the if else constructs is
used instead of the continue statement.

Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
This commit is contained in:
Javier Martinez Canillas 2015-12-11 15:16:33 -02:00 committed by Mauro Carvalho Chehab
parent d8a2cf41cc
commit 1488eee3b4
1 changed files with 5 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/media/platform/vsp1/vsp1_drv.c
View File

@ -264,19 +264,15 @@ static int vsp1_create_entities(struct vsp1_device *vsp1)
ret = vsp1_wpf_create_links(vsp1, entity);
if (ret < 0)
goto done;
continue;
}
if (entity->type == VSP1_ENTITY_RPF) {
} else if (entity->type == VSP1_ENTITY_RPF) {
ret = vsp1_rpf_create_links(vsp1, entity);
if (ret < 0)
goto done;
continue;
} else {
ret = vsp1_create_links(vsp1, entity);
if (ret < 0)
goto done;
}
ret = vsp1_create_links(vsp1, entity);
if (ret < 0)
goto done;
}
if (vsp1->pdata.features & VSP1_HAS_LIF) {