iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

quota: Remove bogus 'optimization' in check_idq() and check_bdq()

Browse Source 
Checks like <= 0 for an unsigned type do not make much sence. The value
could be only 0 and that does not happen often enough for the check
to be worth it.

Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Mark Fasheh <mfasheh@suse.com>
This commit is contained in:
Jan Kara 2008-08-20 15:49:59 +02:00 committed by Mark Fasheh
parent 12095460f7
commit 1497d3ad48
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
fs/dquot.c
View File

@ -1041,7 +1041,7 @@ static inline char ignore_hardlimit(struct dquot *dquot)
static int check_idq(struct dquot *dquot, qsize_t inodes, char *warntype) static int check_idq(struct dquot *dquot, qsize_t inodes, char *warntype)
{ {
*warntype = QUOTA_NL_NOWARN; *warntype = QUOTA_NL_NOWARN;
if (inodes <= 0 || test_bit(DQ_FAKE_B, &dquot->dq_flags)) if (test_bit(DQ_FAKE_B, &dquot->dq_flags))
return QUOTA_OK; return QUOTA_OK;
if (dquot->dq_dqb.dqb_ihardlimit && if (dquot->dq_dqb.dqb_ihardlimit &&
@ -1073,7 +1073,7 @@ static int check_idq(struct dquot *dquot, qsize_t inodes, char *warntype)
static int check_bdq(struct dquot *dquot, qsize_t space, int prealloc, char *warntype) static int check_bdq(struct dquot *dquot, qsize_t space, int prealloc, char *warntype)
{ {
*warntype = QUOTA_NL_NOWARN; *warntype = QUOTA_NL_NOWARN;
if (space <= 0 || test_bit(DQ_FAKE_B, &dquot->dq_flags)) if (test_bit(DQ_FAKE_B, &dquot->dq_flags))
return QUOTA_OK; return QUOTA_OK;
if (dquot->dq_dqb.dqb_bhardlimit && if (dquot->dq_dqb.dqb_bhardlimit &&