iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

spi: spi-topcliff-pch: drop call to wakeup-disable

Browse Source 
Before generic upgrade, both .suspend() and .resume() were invoking
pci_enable_wake(pci_dev, PCI_D3hot, 0). Hence, disabling wakeup in both
states. (Normal trend is .suspend() enables and .resume() disables the
wakeup.)

This was ambiguous and may be buggy. Instead of replicating the legacy
behavior, drop the wakeup-disable call.

Fixes: f185bcc779 ("spi: spi-topcliff-pch: use generic power management")
Reported-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20200727172936.661567-1-vaibhavgupta40@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Vaibhav Gupta 2020-07-27 22:59:37 +05:30 committed by Mark Brown
parent aa9e862d7d
commit 15b413d93c
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/spi/spi-topcliff-pch.c
View File

@ -1652,8 +1652,6 @@ static int __maybe_unused pch_spi_resume(struct device *dev)
dev_dbg(dev, "%s ENTRY\n", __func__);
device_wakeup_disable(dev);
/* set suspend status to false */
pd_dev_save->board_dat->suspend_sts = false;