iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

greybus: operation: drop redundant oom message

Browse Source 
Drop redundant OOM message, which would already have been logged by the
memory subsystem.

Also remove a FIXME about possibly sending a pre-allocated response,
which is neither possible or desirable. If we ever run out of memory we
have bigger problems then getting a response back to firmware.

Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
This commit is contained in:
Johan Hovold 2015-07-01 12:37:29 +02:00 committed by Greg Kroah-Hartman
parent 2593261d5c
commit 1635304d63
1 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/staging/greybus/operation.c
View File

@ -673,12 +673,8 @@ static int gb_operation_response_send(struct gb_operation *operation,
return 0;
if (!operation->response) {
if (!gb_operation_response_alloc(operation, 0)) {
dev_err(&connection->dev,
"error allocating response\n");
/* XXX Respond with pre-allocated -ENOMEM? */
if (!gb_operation_response_alloc(operation, 0))
return -ENOMEM;
}
}
/* Reference will be dropped when message has been sent. */