iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

nvmem: qfprom: Mark core clk as optional

Browse Source 
On some platforms like sc7280 on non-ChromeOS devices the core clock
cannot be touched by Linux so we cannot provide it. Mark it as optional
as accessing qfprom for reading works without it but we still prohibit
writing if we cannot provide the clock.

Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20231020105545.216052-2-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Luca Weiss 2023-10-20 11:55:40 +01:00 committed by Greg Kroah-Hartman
parent 2399cde86e
commit 16724d6ea4
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/nvmem/qfprom.c
View File

@ -423,12 +423,12 @@ static int qfprom_probe(struct platform_device *pdev)
if (IS_ERR(priv->vcc)) if (IS_ERR(priv->vcc))
return PTR_ERR(priv->vcc); return PTR_ERR(priv->vcc);
priv->secclk = devm_clk_get(dev, "core"); priv->secclk = devm_clk_get_optional(dev, "core");
if (IS_ERR(priv->secclk)) if (IS_ERR(priv->secclk))
return dev_err_probe(dev, PTR_ERR(priv->secclk), "Error getting clock\n"); return dev_err_probe(dev, PTR_ERR(priv->secclk), "Error getting clock\n");
/* Only enable writing if we have SoC data. */ /* Only enable writing if we have SoC data and a valid clock */
if (priv->soc_data) if (priv->soc_data && priv->secclk)
econfig.reg_write = qfprom_reg_write; econfig.reg_write = qfprom_reg_write;
} }