iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

greybus: endo: fix use-after-free in error path

Browse Source 
Fix use-after-free in endo-registration error path by moving the
id-release to the device release function.

Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
This commit is contained in:
Johan Hovold 2015-10-21 11:51:42 +02:00 committed by Greg Kroah-Hartman
parent d517f274e9
commit 16cd787d2d
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/staging/greybus/endo.c
View File

@ -113,6 +113,7 @@ static void gb_endo_release(struct device *dev)
{
struct gb_endo *endo = to_gb_endo(dev);
ida_simple_remove(&greybus_endo_id_map, endo->dev_id);
kfree(endo);
}
@ -462,7 +463,6 @@ static int gb_endo_register(struct greybus_host_device *hd,
dev_err(hd->parent, "failed to add endo device of id 0x%04x\n",
endo->id);
put_device(&endo->dev);
ida_simple_remove(&greybus_endo_id_map, endo->dev_id);
}
return retval;
@ -518,7 +518,6 @@ void gb_endo_remove(struct gb_endo *endo)
/* remove all modules for this endo */
gb_module_remove_all(endo);
ida_simple_remove(&greybus_endo_id_map, endo->dev_id);
device_unregister(&endo->dev);
}