iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

afs: Fix error handling with lookup via FS.InlineBulkStatus

Browse Source 
When afs does a lookup, it tries to use FS.InlineBulkStatus to preemptively
look up a bunch of files in the parent directory and cache this locally, on
the basis that we might want to look at them too (for example if someone
does an ls on a directory, they may want want to then stat every file
listed).

FS.InlineBulkStatus can be considered a compound op with the normal abort
code applying to the compound as a whole.  Each status fetch within the
compound is then given its own individual abort code - but assuming no
error that prevents the bulk fetch from returning the compound result will
be 0, even if all the constituent status fetches failed.

At the conclusion of afs_do_lookup(), we should use the abort code from the
appropriate status to determine the error to return, if any - but instead
it is assumed that we were successful if the op as a whole succeeded and we
return an incompletely initialised inode, resulting in ENOENT, no matter
the actual reason.  In the particular instance reported, a vnode with no
permission granted to be accessed is being given a UAEACCES abort code
which should be reported as EACCES, but is instead being reported as
ENOENT.

Fix this by abandoning the inode (which will be cleaned up with the op) if
file[1] has an abort code indicated and turn that abort code into an error
instead.

Whilst we're at it, add a tracepoint so that the abort codes of the
individual subrequests of FS.InlineBulkStatus can be logged.  At the moment
only the container abort code can be 0.

Fixes: e49c7b2f6d ("afs: Build an abstraction around an "operation" concept")
Reported-by: Jeffrey Altman <jaltman@auristor.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: Marc Dionne <marc.dionne@auristor.com>
cc: linux-afs@lists.infradead.org
This commit is contained in:
David Howells 2024-01-02 14:02:37 +00:00
parent 57e9d49c54
commit 17ba6f0bd1
2 changed files with 34 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
fs/afs/dir.c
View File

@ -716,6 +716,8 @@ static void afs_do_lookup_success(struct afs_operation *op)
break; break;
} }
if (vp->scb.status.abort_code)
trace_afs_bulkstat_error(op, &vp->fid, i, vp->scb.status.abort_code);
if (!vp->scb.have_status && !vp->scb.have_error) if (!vp->scb.have_status && !vp->scb.have_error)
continue; continue;
@ -905,13 +907,17 @@ static struct inode *afs_do_lookup(struct inode *dir, struct dentry *dentry,
afs_begin_vnode_operation(op); afs_begin_vnode_operation(op);
afs_wait_for_operation(op); afs_wait_for_operation(op);
} }
inode = ERR_PTR(afs_op_error(op));
out_op: out_op:
if (!afs_op_error(op)) { if (!afs_op_error(op)) {
if (op->file[1].scb.status.abort_code) {
afs_op_accumulate_error(op, -ECONNABORTED,
op->file[1].scb.status.abort_code);
} else {
inode = &op->file[1].vnode->netfs.inode; inode = &op->file[1].vnode->netfs.inode;
op->file[1].vnode = NULL; op->file[1].vnode = NULL;
} }
}
if (op->file[0].scb.have_status) if (op->file[0].scb.have_status)
dentry->d_fsdata = (void *)(unsigned long)op->file[0].scb.status.data_version; dentry->d_fsdata = (void *)(unsigned long)op->file[0].scb.status.data_version;

25
include/trace/events/afs.h
View File

@ -1071,6 +1071,31 @@ TRACE_EVENT(afs_file_error,
__print_symbolic(__entry->where, afs_file_errors)) __print_symbolic(__entry->where, afs_file_errors))
); );
TRACE_EVENT(afs_bulkstat_error,
TP_PROTO(struct afs_operation *op, struct afs_fid *fid, unsigned int index, s32 abort),
TP_ARGS(op, fid, index, abort),
TP_STRUCT__entry(
__field_struct(struct afs_fid, fid)
__field(unsigned int, op)
__field(unsigned int, index)
__field(s32, abort)
),
TP_fast_assign(
__entry->op = op->debug_id;
__entry->fid = *fid;
__entry->index = index;
__entry->abort = abort;
),
TP_printk("OP=%08x[%02x] %llx:%llx:%x a=%d",
__entry->op, __entry->index,
__entry->fid.vid, __entry->fid.vnode, __entry->fid.unique,
__entry->abort)
);
TRACE_EVENT(afs_cm_no_server, TRACE_EVENT(afs_cm_no_server,
TP_PROTO(struct afs_call *call, struct sockaddr_rxrpc *srx), TP_PROTO(struct afs_call *call, struct sockaddr_rxrpc *srx),