iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

drm/atomic: Rework the object doc a bit

Browse Source 
Commits 63e83c1dba ("drm: Consolidate connector arrays in
drm_atomic_state"), b8b5342b69 ("drm: Consolidate plane arrays in
drm_atomic_state") and 5d943aa6c0 ("drm: Consolidate crtc arrays in
drm_atomic_state") moved the object pointer and their state pointer to
an intermediate structure storing both.

The CRTC commit didn't update the doc of the crtcs field to reflect
that, and the doc for the planes and connectors fields mention that they
are pointers to an array of structures with per-$OBJECT data.

The private_objs field was added later on by commit b430c27a7d ("drm:
Add driver-private objects to atomic state") reusing the same sentence
than the crtcs field, probably due to copy and paste.

While these fields are indeed pointers to an array, each item of that
array contain a pointer to the object structure affected by the update,
and its old and new state. There's no per-object data there, and there's
more than just a pointer to the objects.

Let's rephrase those fields a bit to better match the current situation.

Acked-by: Sui Jingfeng <sui.jingfeng@linux.dev>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://lore.kernel.org/r/20231214100917.277842-3-mripard@kernel.org
Signed-off-by: Maxime Ripard <mripard@kernel.org>
This commit is contained in:
Maxime Ripard 2023-12-14 11:09:14 +01:00
parent 786f6c2fa4
commit 17beda5e95
No known key found for this signature in database
GPG Key ID: E3EF0D6F671851C5
1 changed files with 16 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
include/drm/drm_atomic.h
View File

@ -403,12 +403,18 @@ struct drm_atomic_state {
bool duplicated : 1;
/**
* @planes: pointer to array of structures with per-plane data
* @planes:
*
* Pointer to array of @drm_plane and @drm_plane_state part of this
* update.
*/
struct __drm_planes_state *planes;
/**
* @crtcs: pointer to array of CRTC pointers
* @crtcs:
*
* Pointer to array of @drm_crtc and @drm_crtc_state part of this
* update.
*/
struct __drm_crtcs_state *crtcs;
@ -418,7 +424,10 @@ struct drm_atomic_state {
int num_connector;
/**
* @connectors: pointer to array of structures with per-connector data
* @connectors:
*
* Pointer to array of @drm_connector and @drm_connector_state part of
* this update.
*/
struct __drm_connnectors_state *connectors;
@ -428,7 +437,10 @@ struct drm_atomic_state {
int num_private_objs;
/**
* @private_objs: pointer to array of private object pointers
* @private_objs:
*
* Pointer to array of @drm_private_obj and @drm_private_obj_state part
* of this update.
*/
struct __drm_private_objs_state *private_objs;