iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ACPI: CPPC: Fix reference count leak in acpi_cppc_processor_probe()

Browse Source 
commit 4d8be4bc94f74bb7d096e1c2e44457b530d5a170 upstream.

kobject_init_and_add() takes reference even when it fails.
If this function returns an error, kobject_put() must be called to
properly clean up the memory associated with the object. Previous
commit "b8eb718348b8" fixed a similar problem.

Fixes: 158c998ea44b ("ACPI / CPPC: add sysfs support to compute delivered performance")
Signed-off-by: Qiushi Wu <wu000273@umn.edu>
Cc: 4.10+ <stable@vger.kernel.org> # 4.10+
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Qiushi Wu 2020-05-27 17:35:51 -05:00 committed by Greg Kroah-Hartman
parent bdce493344
commit 17cac70bdf
1 changed files with 3 additions and 1 deletions

4
drivers/acpi/cppc_acpi.c

@ -793,8 +793,10 @@ int acpi_cppc_processor_probe(struct acpi_processor *pr)
ret = kobject_init_and_add(&cpc_ptr->kobj, &cppc_ktype, &cpu_dev->kobj,
"acpi_cppc");
if (ret)
if (ret) {
kobject_put(&cpc_ptr->kobj);
goto out_free;
}
kfree(output.pointer);
return 0;