iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tools/memory-model: Make read_foo_diagnostic() more clearly diagnostic

Browse Source 
The current definition of read_foo_diagnostic() in the "Lock Protection
With Lockless Diagnostic Access" section returns a value, which could
be use for any purpose.  This could mislead people into incorrectly
using data_race() in cases where READ_ONCE() is required.  This commit
therefore makes read_foo_diagnostic() simply print the value read.

Reported-by: Manfred Spraul <manfred@colorfullife.com>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
This commit is contained in:
Paul E. McKenney 2021-05-13 11:17:02 -07:00
parent 2734d6c1b1
commit 1846a7fa76
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tools/memory-model/Documentation/access-marking.txt
View File

@ -259,9 +259,9 @@ diagnostic purposes. The code might look as follows:
return ret; return ret;
} }
int read_foo_diagnostic(void) void read_foo_diagnostic(void)
{ {
return data_race(foo); pr_info("Current value of foo: %d\n", data_race(foo));
} }
The reader-writer lock prevents the compiler from introducing concurrency The reader-writer lock prevents the compiler from introducing concurrency