iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mt76: mt7615: fix possible division by 0 in mt7615_mac_update_mib_stats

Browse Source 
Check that val is not zero before aggr_per estimation in order to avoid a
possible division by 0

Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
This commit is contained in:
Lorenzo Bianconi 2020-04-06 23:56:30 +02:00 committed by Felix Fietkau
parent 9a865741d8
commit 1855ad5360
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/net/wireless/mediatek/mt76/mt7615/mac.c
View File

@ -1773,9 +1773,11 @@ mt7615_mac_update_mib_stats(struct mt7615_phy *phy)
val = mt76_get_field(dev, MT_MIB_SDR14(ext_phy),
MT_MIB_AMPDU_MPDU_COUNT);
val2 = mt76_get_field(dev, MT_MIB_SDR15(ext_phy),
MT_MIB_AMPDU_ACK_COUNT);
mib->aggr_per = 1000 * (val - val2) / val;
if (val) {
val2 = mt76_get_field(dev, MT_MIB_SDR15(ext_phy),
MT_MIB_AMPDU_ACK_COUNT);
mib->aggr_per = 1000 * (val - val2) / val;
}
aggr = ext_phy ? ARRAY_SIZE(dev->mt76.aggr_stats) / 2 : 0;
for (i = 0; i < 4; i++) {