iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ibmtr: possible Read buffer overflow?

Browse Source 
Prevent read outside array bounds.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
roel kluin 2009-10-03 11:26:55 +00:00 committed by David S. Miller
parent b0c110ca8e
commit 18eb0893c1
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/net/tokenring/ibmtr.c
View File

@ -1143,9 +1143,16 @@ static void dir_open_adapter (struct net_device *dev)
} else { } else {
char **prphase = printphase; char **prphase = printphase;
char **prerror = printerror; char **prerror = printerror;
int pnr = err / 16 - 1;
int enr = err % 16 - 1;
DPRINTK("TR Adapter misc open failure, error code = "); DPRINTK("TR Adapter misc open failure, error code = ");
printk("0x%x, Phase: %s, Error: %s\n", if (pnr < 0 || pnr >= ARRAY_SIZE(printphase) ||
err, prphase[err/16 -1], prerror[err%16 -1]); enr < 0 ||
enr >= ARRAY_SIZE(printerror))
printk("0x%x, invalid Phase/Error.", err);
else
printk("0x%x, Phase: %s, Error: %s\n", err,
prphase[pnr], prerror[enr]);
printk(" retrying after %ds delay...\n", printk(" retrying after %ds delay...\n",
TR_RETRY_INTERVAL/HZ); TR_RETRY_INTERVAL/HZ);
} }