iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

securityfs: fix securityfs_create_dir comment

Browse Source 
If there is an error creating a directory with securityfs_create_dir,
the error is propagated via ERR_PTR but the function comment claims that
NULL is returned.

This is a similar commit to 88e6c94cda322ff2b32f72bb8d96f9675cdad8aa
("fix long-broken securityfs_create_file comment") that did not fix
securityfs_create_dir comment at the same time.

Signed-off-by: Laurent Georget <laurent.georget@supelec.fr>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
This commit is contained in:
Laurent Georget 2016-07-13 08:58:40 +02:00 committed by Jiri Kosina
parent 3da7ffecb7
commit 1b4606511d
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
security/inode.c
View File

@ -156,12 +156,11 @@ EXPORT_SYMBOL_GPL(securityfs_create_file);
* This function returns a pointer to a dentry if it succeeds. This * This function returns a pointer to a dentry if it succeeds. This
* pointer must be passed to the securityfs_remove() function when the file is * pointer must be passed to the securityfs_remove() function when the file is
* to be removed (no automatic cleanup happens if your module is unloaded, * to be removed (no automatic cleanup happens if your module is unloaded,
* you are responsible here). If an error occurs, %NULL will be returned. * you are responsible here). If an error occurs, the function will return
* the error value (via ERR_PTR).
* *
* If securityfs is not enabled in the kernel, the value %-ENODEV is * If securityfs is not enabled in the kernel, the value %-ENODEV is
* returned. It is not wise to check for this value, but rather, check for * returned.
* %NULL or !%NULL instead as to eliminate the need for #ifdef in the calling
* code.
*/ */
struct dentry *securityfs_create_dir(const char *name, struct dentry *parent) struct dentry *securityfs_create_dir(const char *name, struct dentry *parent)
{ {