iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

drivers/isdn/mISDN/stack.c: remove invalid reference to list iterator variable

Browse Source 
If list_for_each_entry, etc complete a traversal of the list, the iterator
variable ends up pointing to an address at an offset from the list head,
and not a meaningful structure.  Thus this value should not be used after
the end of the iterator.  The dereferences are just deleted from the
debugging statement.

This problem was found using Coccinelle (http://coccinelle.lip6.fr/).

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Julia Lawall 2012-07-08 01:37:38 +00:00 committed by David S. Miller
parent 91c68ce2b2
commit 1b9faf5e66
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/isdn/mISDN/stack.c
View File

@ -135,8 +135,8 @@ send_layer2(struct mISDNstack *st, struct sk_buff *skb)
skb = NULL; skb = NULL;
else if (*debug & DEBUG_SEND_ERR) else if (*debug & DEBUG_SEND_ERR)
printk(KERN_DEBUG printk(KERN_DEBUG
"%s ch%d mgr prim(%x) addr(%x) err %d\n", "%s mgr prim(%x) err %d\n",
__func__, ch->nr, hh->prim, ch->addr, ret); __func__, hh->prim, ret);
} }
out: out:
mutex_unlock(&st->lmutex); mutex_unlock(&st->lmutex);