iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

leds: max8997: Use devm_led_classdev_register

Browse Source 
Switch to resource-managed function devm_led_classdev_register instead
of led_classdev_register and remove unneeded led_classdev_unregister.

Also, remove platform_set_drvdata in probe function and the remove
function, max8997_led_remove as it is now has nothing to do.

The Coccinelle semantic patch used to make this change is as follows:
//<smpl>
@platform@
identifier p, probefn, removefn;
@@
struct platform_driver p = {
  .probe = probefn,
  .remove = removefn,
};

@prb@
identifier platform.probefn, pdev;
expression e;
@@
probefn(struct platform_device *pdev, ...) {
  ...
  e =
- led_classdev_register
+ devm_led_classdev_register
  (...);
   ...
?- led_classdev_unregister(...);
  ...
}
@remove depends on prb@
identifier platform.removefn;
@@
removefn(...) {
...
?- led_classdev_unregister(...);
...
}
//</smpl>

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
This commit is contained in:
Amitoj Kaur Chawla 2016-03-09 08:54:32 +05:30 committed by Jacek Anaszewski
parent eed16255d6
commit 1c430f9021
1 changed files with 1 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/leds/leds-max8997.c
View File

@ -281,30 +281,18 @@ static int max8997_led_probe(struct platform_device *pdev)
mutex_init(&led->mutex); mutex_init(&led->mutex);
platform_set_drvdata(pdev, led); ret = devm_led_classdev_register(&pdev->dev, &led->cdev);
ret = led_classdev_register(&pdev->dev, &led->cdev);
if (ret < 0) if (ret < 0)
return ret; return ret;
return 0; return 0;
} }
static int max8997_led_remove(struct platform_device *pdev)
{
struct max8997_led *led = platform_get_drvdata(pdev);
led_classdev_unregister(&led->cdev);
return 0;
}
static struct platform_driver max8997_led_driver = { static struct platform_driver max8997_led_driver = {
.driver = { .driver = {
.name = "max8997-led", .name = "max8997-led",
}, },
.probe = max8997_led_probe, .probe = max8997_led_probe,
.remove = max8997_led_remove,
}; };
module_platform_driver(max8997_led_driver); module_platform_driver(max8997_led_driver);