iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

usb: fix a few cases of -Wfallthrough

Browse Source 
The "fallthrough" pseudo-keyword was added as a portable way to denote
intentional fallthrough. Clang will still warn on cases where there is a
fallthrough to an immediate break. Add explicit breaks for those cases.

Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Link: https://lore.kernel.org/r/20201111014716.260633-1-ndesaulniers@google.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Nick Desaulniers 2020-11-10 17:47:14 -08:00 committed by Greg Kroah-Hartman
parent 57cde55122
commit 1d6903a617
5 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
drivers/usb/core/config.c
View File

@ -1076,6 +1076,7 @@ int usb_get_bos_descriptor(struct usb_device *dev)
case USB_PTM_CAP_TYPE: case USB_PTM_CAP_TYPE:
dev->bos->ptm_cap = dev->bos->ptm_cap =
(struct usb_ptm_cap_descriptor *)buffer; (struct usb_ptm_cap_descriptor *)buffer;
break;
default: default:
break; break;
} }

2
drivers/usb/host/ehci-hcd.c
View File

@ -867,7 +867,7 @@ static int ehci_urb_enqueue (
*/ */
if (urb->transfer_buffer_length > (16 * 1024)) if (urb->transfer_buffer_length > (16 * 1024))
return -EMSGSIZE; return -EMSGSIZE;
/* FALLTHROUGH */ fallthrough;
/* case PIPE_BULK: */ /* case PIPE_BULK: */
default: default:
if (!qh_urb_transaction (ehci, urb, &qtd_list, mem_flags)) if (!qh_urb_transaction (ehci, urb, &qtd_list, mem_flags))

2
drivers/usb/host/ohci-hcd.c
View File

@ -171,7 +171,7 @@ static int ohci_urb_enqueue (
/* 1 TD for setup, 1 for ACK, plus ... */ /* 1 TD for setup, 1 for ACK, plus ... */
size = 2; size = 2;
/* FALLTHROUGH */ fallthrough;
// case PIPE_INTERRUPT: // case PIPE_INTERRUPT:
// case PIPE_BULK: // case PIPE_BULK:
default: default:

1
drivers/usb/host/ohci-hub.c
View File

@ -692,6 +692,7 @@ int ohci_hub_control(
case C_HUB_OVER_CURRENT: case C_HUB_OVER_CURRENT:
ohci_writel (ohci, RH_HS_OCIC, ohci_writel (ohci, RH_HS_OCIC,
&ohci->regs->roothub.status); &ohci->regs->roothub.status);
break;
case C_HUB_LOCAL_POWER: case C_HUB_LOCAL_POWER:
break; break;
default: default:

2
drivers/usb/host/xhci-ring.c
View File

@ -2418,6 +2418,7 @@ static int handle_tx_event(struct xhci_hcd *xhci,
xhci_warn_ratelimited(xhci, xhci_warn_ratelimited(xhci,
"WARN Successful completion on short TX for slot %u ep %u: needs XHCI_TRUST_TX_LENGTH quirk?\n", "WARN Successful completion on short TX for slot %u ep %u: needs XHCI_TRUST_TX_LENGTH quirk?\n",
slot_id, ep_index); slot_id, ep_index);
break;
case COMP_SHORT_PACKET: case COMP_SHORT_PACKET:
break; break;
/* Completion codes for endpoint stopped state */ /* Completion codes for endpoint stopped state */
@ -2962,6 +2963,7 @@ static int prepare_ring(struct xhci_hcd *xhci, struct xhci_ring *ep_ring,
return -EINVAL; return -EINVAL;
case EP_STATE_HALTED: case EP_STATE_HALTED:
xhci_dbg(xhci, "WARN halted endpoint, queueing URB anyway.\n"); xhci_dbg(xhci, "WARN halted endpoint, queueing URB anyway.\n");
break;
case EP_STATE_STOPPED: case EP_STATE_STOPPED:
case EP_STATE_RUNNING: case EP_STATE_RUNNING:
break; break;