iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

riscv: cleanup send_ipi_mask

Browse Source 
Use the special barriers for atomic bitops to make the intention
a little more clear, and use riscv_cpuid_to_hartid_mask instead of
open coding it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Atish Patra <atish.patra@wdc.com>
Signed-off-by: Paul Walmsley <paul.walmsley@sifive.com>
This commit is contained in:
Christoph Hellwig 2019-08-21 23:58:33 +09:00 committed by Paul Walmsley
parent 7e0e50895f
commit 1db7a7ca5a
1 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
arch/riscv/kernel/smp.c
View File

@ -80,17 +80,15 @@ static void ipi_stop(void)
static void send_ipi_mask(const struct cpumask *mask, enum ipi_message_type op) static void send_ipi_mask(const struct cpumask *mask, enum ipi_message_type op)
{ {
int cpuid, hartid;
struct cpumask hartid_mask; struct cpumask hartid_mask;
int cpu;
cpumask_clear(&hartid_mask); smp_mb__before_atomic();
mb(); for_each_cpu(cpu, mask)
for_each_cpu(cpuid, mask) { set_bit(op, &ipi_data[cpu].bits);
set_bit(op, &ipi_data[cpuid].bits); smp_mb__after_atomic();
hartid = cpuid_to_hartid_map(cpuid);
cpumask_set_cpu(hartid, &hartid_mask); riscv_cpuid_to_hartid_mask(mask, &hartid_mask);
}
mb();
sbi_send_ipi(cpumask_bits(&hartid_mask)); sbi_send_ipi(cpumask_bits(&hartid_mask));
} }