iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

octeon_ep: delete unnecessary NULL check

Browse Source 
vfree(NULL) is safe. NULL check before vfree() is not needed.
Delete them to simplify the code.

Signed-off-by: Ziyang Xuan <william.xuanziyang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Ziyang Xuan 2022-05-13 15:29:28 +08:00 committed by David S. Miller
parent e68372efb9
commit 1dee43c2c6
3 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/net/ethernet/marvell/octeon_ep/octep_main.c
View File

@ -980,8 +980,7 @@ static void octep_device_cleanup(struct octep_device *oct)
dev_info(&oct->pdev->dev, "Cleaning up Octeon Device ...\n");
for (i = 0; i < OCTEP_MAX_VF; i++) {
if (oct->mbox[i])
vfree(oct->mbox[i]);
vfree(oct->mbox[i]);
oct->mbox[i] = NULL;
}

3
drivers/net/ethernet/marvell/octeon_ep/octep_rx.c
View File

@ -230,8 +230,7 @@ static int octep_free_oq(struct octep_oq *oq)
octep_oq_free_ring_buffers(oq);
if (oq->buff_info)
vfree(oq->buff_info);
vfree(oq->buff_info);
if (oq->desc_ring)
dma_free_coherent(oq->dev,

3
drivers/net/ethernet/marvell/octeon_ep/octep_tx.c
View File

@ -270,8 +270,7 @@ static void octep_free_iq(struct octep_iq *iq)
desc_ring_size = OCTEP_IQ_DESC_SIZE * CFG_GET_IQ_NUM_DESC(oct->conf);
if (iq->buff_info)
vfree(iq->buff_info);
vfree(iq->buff_info);
if (iq->desc_ring)
dma_free_coherent(iq->dev, desc_ring_size,